Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Allow local IPv6 connections to Postgres (bp #1257)" #1480

Merged
merged 1 commit into from May 3, 2020

Conversation

muhlemmer
Copy link
Member

@muhlemmer muhlemmer commented May 3, 2020

Reverts #1469

Fixes #1479

@mergify
Copy link
Contributor

mergify bot commented May 3, 2020

Thanks for submitting this pull request.
Bors-ng will now build test images. When it succeeds, we will continue to review and test your PR.

bors try

Note: if this build fails, read this.

bors bot added a commit that referenced this pull request May 3, 2020
@muhlemmer muhlemmer merged commit b02d182 into 1.7 May 3, 2020
@bors
Copy link
Contributor

bors bot commented May 3, 2020

try

Build succeeded:

bors bot added a commit that referenced this pull request May 5, 2020
1481: Postgresql: default SUBNET6 in pg_hba r=mergify[bot] a=muhlemmer

## What type of PR?

Bug fix

## What does this PR do?

When PostgreSQL for Mailu is used in IPv4 only, without IPv6, `SUBNET6` is unset and causes an empty field in the `pg_hba.conf` file.  PostgreSQL refuses to start in this case.

### Related issue(s)
- Bug was introduced in #1257, merged recently
- 1.7 user reported PostgreSQL connection errors on IPv6 in #1479
- #1257 was Backported to 1.7 in #1469 
- Users on 1.7 reported this broke IPv4 installation in #1479 
- Backport was reverted in #1480 

Sorry for the mess 😒 

**Note: ** if this patch seems to be stable, I will re-initiate the backport.

## Prerequistes
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

- [x] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/guide.html#changelog) entry file.


Co-authored-by: Tim Möhlmann <muhlemmer@gmail.com>
@Diman0 Diman0 deleted the revert-1469-mergify/bp/1.7/pr-1257 branch August 31, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant