Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Docker Swarm stack example. #284 #344

Closed
wants to merge 1 commit into from
Closed

Add a Docker Swarm stack example. #284 #344

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 3, 2017

No description provided.

@kaiyou
Copy link
Member

kaiyou commented Dec 5, 2017

This looks pretty good, just have a look at the documentation for Docker-Compose about adding proper links to configuration files and I think we can merge.

@kaiyou
Copy link
Member

kaiyou commented Dec 5, 2017

Also, does Swarm support variables in Compose files? in that case, it would be interesting to keep version variables, root path and so on.

@ghost
Copy link
Author

ghost commented Dec 5, 2017

I am not sure about vars in the stack file. But I know what there is no .env support (at least yet) - moby/moby#29133 (comment)

@ghost
Copy link
Author

ghost commented Dec 5, 2017

And this ^ is why I needed env vars documentation - to at least somehow decrease variable duplication degree in the stack file.

@kaiyou
Copy link
Member

kaiyou commented Dec 5, 2017

Okay then. So I would suggest a couple improvements:

  • use the same defaults as for the Compose configuration
  • use dynamic links in the document and so on
  • add a warning in the documentation that this is for version 1.4 until you support 1.5.

@kaiyou
Copy link
Member

kaiyou commented Dec 5, 2017

Also, could you merge against master?

@rgarrigue
Copy link

Hi

I guess setting webdav's image to mailu/none ought to be mailu/radicale ?

Best regards,

@rgarrigue
Copy link

And that won't work as is I think

Ignoring deprecated options:

expose: Exposing ports is unnecessary - services on the same network can access each other's containers on any port.

@muhlemmer
Copy link
Member

muhlemmer commented Sep 20, 2018

This PR is pretty old, incomplete and the submitter seems to have deleted his Github account (Ghost). Furthermore, the docs seem already to be handled in PR #551.

@kaiyou , I would propose to Close this PR as rejected.

@kaiyou
Copy link
Member

kaiyou commented Sep 21, 2018

Agrees since #551 does a pretty good job of this.

@kaiyou kaiyou closed this Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants