-
-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Docker Swarm stack example. #284 #344
Conversation
This looks pretty good, just have a look at the documentation for Docker-Compose about adding proper links to configuration files and I think we can merge. |
Also, does Swarm support variables in Compose files? in that case, it would be interesting to keep version variables, root path and so on. |
I am not sure about vars in the stack file. But I know what there is no .env support (at least yet) - moby/moby#29133 (comment) |
And this ^ is why I needed env vars documentation - to at least somehow decrease variable duplication degree in the stack file. |
Okay then. So I would suggest a couple improvements:
|
Also, could you merge against |
Hi I guess setting webdav's image to mailu/none ought to be mailu/radicale ? Best regards, |
And that won't work as is I think
|
Agrees since #551 does a pretty good job of this. |
No description provided.