Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow existing PVC and PV to make it work with Rancher 2.0 #13

Closed
wants to merge 19 commits into from

Conversation

soriyath
Copy link
Contributor

@soriyath soriyath commented Jan 26, 2020

Hello All,

I've made some changes so that I can install the helm chart for mailu on my Rancher v2.3.4 environment.

In that regard, I have:

  • added a few new parameters to the persistence parameters;
  • kept the hostingPath persistence type per default;
  • added the mailu.claimName convenience variable as an indirection to the PVC (defaulting to mailu-storage as per before);
  • updated the README.md file with some more context.

Please note, in order to install it on my server, I've created a helm repo on my Github page.
You will see the artifact and the index.yaml, as well as some config files for GitHub page on the PR.
I can either remove them or we can delete them after the merge. I'm keeping it like this as there probably will be review comments for modifications.

Best Regards,

Soriyath

@soriyath soriyath requested a review from micw January 26, 2020 15:20
Copy link
Contributor

@micw micw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the binary files from the built charts from the PR

We have 3 situations to handle:
hostpath: create PV and PVC that uses this PV
managed PVs: create PVC but no PV
(new) existing claim: use existing claim name, create neither PV nor PVC

Please edit pvc.yaml accordingly, I added comments there too

mailu/Chart.yaml Outdated Show resolved Hide resolved
_config.yml Outdated Show resolved Hide resolved
index.yaml Outdated Show resolved Hide resolved
mailu/README.md Outdated Show resolved Hide resolved
mailu/templates/pvc.yaml Outdated Show resolved Hide resolved
mailu/templates/pvc.yaml Outdated Show resolved Hide resolved
mailu/templates/pvc.yaml Show resolved Hide resolved
@micw
Copy link
Contributor

micw commented Jan 29, 2020

Also please rebase against master, I have fixed travis builds for PRs

mailu/templates/pvc.yaml Outdated Show resolved Hide resolved
@soriyath
Copy link
Contributor Author

@micw I've rebased against master and have opened this PR: #17
I would like my master branch to reflect the upstream branch.
Can we close this one and continue the discussion on PR 17?

Also, when linting, I get this error:
[ERROR] templates/: template: mailu/templates/mysql.yaml:1:57: executing "mailu/templates/mysql.yaml" at <.Values.database.mysql.host>: nil pointer evaluating interface {}.host

I think it's unrelated to my changes, is it?

@soriyath soriyath closed this Jan 29, 2020
micw pushed a commit that referenced this pull request Apr 12, 2023
Signed-off-by: fastlorenzo <git@bernardi.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants