New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow existing PVC and PV to make it work with Rancher 2.0 #13
Conversation
Remove obsolete artifacts.
Inject existingClaim into mailu.claimName if provided. Bump release candidate to 0.0.4-rc.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the binary files from the built charts from the PR
We have 3 situations to handle:
hostpath: create PV and PVC that uses this PV
managed PVs: create PVC but no PV
(new) existing claim: use existing claim name, create neither PV nor PVC
Please edit pvc.yaml accordingly, I added comments there too
Also please rebase against master, I have fixed travis builds for PRs |
@micw I've rebased against master and have opened this PR: #17 Also, when linting, I get this error: I think it's unrelated to my changes, is it? |
Signed-off-by: fastlorenzo <git@bernardi.be>
Hello All,
I've made some changes so that I can install the helm chart for mailu on my Rancher v2.3.4 environment.
In that regard, I have:
persistence
parameters;hostingPath
persistence type per default;mailu.claimName
convenience variable as an indirection to the PVC (defaulting tomailu-storage
as per before);README.md
file with some more context.Please note, in order to install it on my server, I've created a helm repo on my Github page.
You will see the artifact and the index.yaml, as well as some config files for GitHub page on the PR.
I can either remove them or we can delete them after the merge. I'm keeping it like this as there probably will be review comments for modifications.
Best Regards,
Soriyath