MAISTRA-1449 Update to 1.4.8 #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
* remove use_downstream_protocol for gateway * comment * writing Co-authored-by: Yan Xue <3491507+yxue@users.noreply.github.com>
Co-authored-by: knrc <knrc@users.noreply.github.com>
* resign certificate * test Co-authored-by: xuzhonghu <xuzhonghu@huawei.com>
This is going to continue to break as istio.io changes. We already disabled this on 1.5/master.
…22171) We already honor it in `go build`, we should do the same in `go test`. Manual backport of istio/istio#22163
This variable needs to be set before used (set -u) and must not be quoted, otherwise it will become an empty arg for go test if it's empty. Co-authored-by: Jonh Wendell <jonh.wendell@redhat.com>
…506) Co-authored-by: gargnupur <gargnupur@google.com>
(cherry picked from commit fdc6dd4) Co-authored-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
* Make sure to use CNI 1.4 image when running tests under CNI * Fix lint
* Update deps with update_deps.sh * Dep updates again
* Run update_deps.sh Had to do go get istio.io/operator@5f8ecc70a0f4059bfd4d0f7867d4dc76407f2f08 since update_deps.sh was not updating it. * Run go mod tidy
* Fix Gateway helm chart for helm 3 Helm 3 threw an error that `$spec.sds` is not a function. Removing the parentheses led to the next problem: the and evaluates eager so `spec.sds.enabled` resulted in a `nil` exception. By nesting the if, the problem is resolved * Also fix the role Co-authored-by: Alex Nederlof <alex@nederlof.com>
|
I'm still running the integration tests. Will update once they're finished. Update: integration tests passed. |
luksa
approved these changes
May 26, 2020
jwendell
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.