Enable injecting additional annotations into pods (MAISTRA-518) #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using Istio CNI through Multus CNI, the pod needs to contain an annotation that tells Multus to use the Istio CNI plugin on the pod. The annotation obviously needs to be injected at pod creation, so the sidecar-injector now allows you to specify any number of additional annotations to inject (in addition to the (init)containers, volumes, etc.)
jwendell
approved these changes
Jun 21, 2019
| } | ||
|
|
||
| for i, c := range cases { | ||
| if c.inputFile != "TestWebhookInject_http_probe_nosidecar_rewrite.yaml" { | ||
| continue | ||
| } |
There was a problem hiding this comment.
Is this an upstream typo/bug/leftover that should be reported/fixed?
There was a problem hiding this comment.
Yes. It was a bug, but it was fixed already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Istio CNI through Multus CNI, the pod needs to contain an
annotation that tells Multus to use the Istio CNI plugin on the pod.
The annotation needs to be injected at pod creation time so that it
already exists when the kubelet starts setting up the pod's network.
Adding the annotation afterwards has no effect, since the pod's network
has already been set up.
For this reason, the sidecar-injector now allows you to specify any
number of additional annotations to inject (in addition to the
(init)containers, volumes, etc.)