[MAISTRA-680] Add the env variable POD_NAMESPACE to telemetry deployment #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As some adapters might rely on that. Currently kubernetesenv adapter is using istio-system namespace, because this env variable does not exist, thus, if the control plane is deployed in other namespace we see errors like that: ``` 2019-07-23T13:32:01.096074Z error istio.io/istio/pkg/kube/secretcontroller/secretcontroller.go:148: Failed to list *v1.Secret: secrets is forbidden: User "system:serviceaccount:i1:istio-mixer-service-account" cannot list resource "secrets" in API group "" in the namespace "istio-system" ```
knrc
approved these changes
Jul 23, 2019
brian-avery
approved these changes
Jul 23, 2019
dgn
pushed a commit
to dgn/istio-maistra
that referenced
this pull request
Jan 28, 2020
* Add build infra for proto to Go structs * Add deepcopy for gogo types used in IstioControlPlane proto * Bypass deepcopy for DynamicAny, not used * WIP * Disable deepcopy until clean solution can be found * Minor updates
dgn
pushed a commit
to dgn/istio-maistra
that referenced
this pull request
Jan 28, 2020
* Recursive directory watcher * Fix initial timer value * Lint * Add copyright * Review comments * Add the codecov setup from istio repo (maistra#32) * Add the codecov setup from istio repo * Add the codecov setup from istio repo * Extend CODEOWNERS (maistra#37) * Add local codecov check script (maistra#23) * Add local codecov check script * Add codecov diff check script to check coverage drop * Add codecov diff check script to check coverage drop * Update common files. (maistra#39) * Add build infra for proto to Go structs (maistra#34) * Add build infra for proto to Go structs * Add deepcopy for gogo types used in IstioControlPlane proto * Bypass deepcopy for DynamicAny, not used * WIP * Disable deepcopy until clean solution can be found * Minor updates * add resources or certmanager. (maistra#45) * Add Environment WG leads to CODEOWNERS (maistra#46) * Refactoring utils (maistra#40) * Refactoring utils * Lint * Copyrights * Minor cleanup * Overview of component package group (maistra#27) * Config and profile samples (maistra#38) * Config and profile samples * Update profiles and sample * Additional fields * Default profile comes from compiled in * Listen also for create and delete events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As some adapters might rely on that.
Currently kubernetesenv adapter is using istio-system namespace,
because this env variable does not exist, thus, if the control plane
is deployed in other namespace we see errors like that: