Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[maistra-869] Update to Kiali docs #95

Merged
merged 2 commits into from
Sep 4, 2019
Merged

[maistra-869] Update to Kiali docs #95

merged 2 commits into from
Sep 4, 2019

Conversation

brian-avery
Copy link
Contributor

No description provided.

@brian-avery brian-avery mentioned this pull request Sep 3, 2019
Closed
@brian-avery brian-avery changed the title [maistra-869] [maistra-866] Update to Kiali docs [maistra-869] Update to Kiali docs Sep 3, 2019
jwendell
jwendell requested changes Sep 3, 2019
View reviewed changes
Copy link
Member

@jwendell jwendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you are making use of the istio-tutorial example to show how to use kiali. Can you make that explicit, i.e., saying that this is an example and link to it?

While reading it, I was expecting that this istio-tutorial namespace existed beforehand.

topics/docs/monitoring_and_tracing/kiali.adoc Outdated Show resolved Hide resolved
topics/docs/monitoring_and_tracing/kiali.adoc Outdated Show resolved Hide resolved
topics/docs/monitoring_and_tracing/kiali.adoc Outdated Show resolved Hide resolved
topics/docs/monitoring_and_tracing/kiali.adoc Outdated Show resolved Hide resolved
topics/docs/monitoring_and_tracing/kiali.adoc Outdated Show resolved Hide resolved
jwendell
jwendell reviewed Sep 4, 2019
View reviewed changes
Copy link
Member

@jwendell jwendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem to be using only two images, not need to add 7 to this pr, right?

dgn
dgn approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@dgn dgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for two minor things

topics/docs/monitoring_and_tracing/kiali.adoc Outdated Show resolved Hide resolved
topics/docs/monitoring_and_tracing/kiali.adoc Outdated Show resolved Hide resolved
@brian-avery
Copy link
Contributor Author

This is part 1 of the Kiali docs. Part two will include the rest of the Kiali tutorial and be added later.

@mergify mergify bot merged commit 623ab7e into maistra:maistra-1.0 Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwendell jwendell jwendell approved these changes

@dgn dgn dgn approved these changes

Assignees
No one assigned
Labels
okay to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brian-avery @jwendell @dgn