Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update web-lib dependency #1

Merged
merged 5 commits into from
Sep 16, 2022
Merged

Conversation

0xMirim
Copy link

@0xMirim 0xMirim commented Sep 5, 2022

Description

This pull request updates the web-lib dependency to the latest version (0.13.15). This changes is necessary because currently when one attempts run yarn to install the dependencies, after making a local copy of the project, an error is returned.

This occurs because the repo currently uses @yearn/web-lib@0.2.20, though it appears that the package scope was updated since then from @yearn/web-lib to @yearn-finance/web-lib, and the original version we relied on no longer exists in the registries.

Notes:

  • The old useBalances context seemed to provide functionality to retrieveBalances whereas the newuseBalances hook doesn't provide this. I'm open to feedback on if this is necessary and how to accomplish this (to possible keep balances up to date after a successful migration) See MigrateBox.tsx changes for more details
  • I personally see a numeric overflow error when running locally coming the attempt to fetch Aave data on Fantom. I'm pushing the code as is to see if it can be reproduced. Some initial attempts at reproduction resulted in no error being present when others ran the code.

Extra:

  • Moved token addresses to separate file to avoid Eslint warning of possibly empty object when using the addresses present available on PROCESS.ENV (next.config.js)
  • Resolved errors around post-css nesting after web-lib dependency update
  • Removed unnecessary CSS styles

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Change details

N/A

Resources

N/A

Made minimal changes required to update web-lib dependency to 0.9.7
@vercel
Copy link

vercel bot commented Sep 5, 2022

@0xMirim is attempting to deploy a commit to the YCorpo Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
y-vempire ✅ Ready (Inspect) Visit Preview Sep 16, 2022 at 8:33AM (UTC)

Copy link
Owner

@Majorfi Majorfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG! Merging to develop to work from there!

@Majorfi Majorfi merged commit fc5446b into Majorfi:develop Sep 16, 2022
@0xMirim 0xMirim deleted the update-web-lib branch September 20, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants