Support timeseries #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the scale type is a timeseries, calculations will be based on the timestamp gathered from the x axis Should allow this plugin to work out of the box with most charts (doesn't affect non-timeseries charts)
wrobbins
reviewed
Jun 22, 2020
| if (data == null) return; | ||
|
|
||
| if (xScale.options.type === "time") | ||
| fitter.add(new Date(data.x).getTime(), data.y); |
There was a problem hiding this comment.
x can also be t according to the docs
There was a problem hiding this comment.
Suggested change
| fitter.add(new Date(data.x).getTime(), data.y); | |
| fitter.add(new Date(data.x || data.t).getTime(), data.y); |
Would do the trick ?
There was a problem hiding this comment.
doh dang I thought I PR'd into your fork #35
|
Big thanks for your PR. Sorry for my late reply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the scale type is a timeseries, calculations will be based on the timestamp gathered from the x axis
Should allow this plugin to work out of the box with most charts (doesn't affect non-timeseries charts)