Added support for v3.x of chartJS #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge this. I can confirm it works via a forked copy with the changes: |
|
I assume you're asking Makanz to merge- I just checked and it says "Only those with write access to this repository can merge pull requests." Again, apologies for the newbie questions. |
Yes haha Sorry for any confusion |
|
Dose this update work with 2.X or only 3.X and above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a few lines to make this plugin support ChartJS v3.x (I tested it with 3.4.1).
This should also take care of the Cannot read property 'register' of undefined issue #54
This is my first time ever trying to contribute to a github project, so I apologize if I did something wrong.