Fix some ES6 syntax issue and add support for getting axis keys from options #85
Conversation
…options xAxis and yAxis keys are currently hard-coded as either 'x', or 't' and 'y'. This change adds support to use the provided xAxisKey and yAxisKey values from the chartjs options object that is provided by the user. Fall back to the original behavior in case these are not provided. This is a non-breaking change. Also, add the 'const' keyword in front of the addFilter method.
elesueur
force-pushed
the
topic/elesueur/fixes-and-axis-key-configs
branch
from
813bc61
to
c9fd2fb
Compare
| const xAxisKey = dataset.trendlineLinear.xAxisKey || parsing ? parsing.xAxisKey : "x"; | ||
| const yAxisKey = dataset.trendlineLinear.yAxisKey || parsing ? parsing.yAxisKey : "y"; |
There was a problem hiding this comment.
Hi @Makanz, I believe this line won't work as intended if dataset.trendlineLinear.xAxisKey has value, it'll throw Cannot read properties of undefined
these lines should be 👇🏼
const xAxisKey = dataset.trendlineLinear.xAxisKey || (parsing ? parsing.xAxisKey : "x");
const yAxisKey = dataset.trendlineLinear.yAxisKey || (parsing ? parsing.yAxisKey : "y");
There was a problem hiding this comment.
Please make a pull request if you have the possibility. Else I will try to take a look at it in a couple of weeks.
There was a problem hiding this comment.
@DialaHamadneh I have released a new version were I have made the change.
https://www.npmjs.com/package/chartjs-plugin-trendline/v/2.1.1
There was a problem hiding this comment.
Thanks @Makanz , it's working 🎉 🙏🏼
xAxis and yAxis keys are currently hard-coded as either 'x', or 't' and 'y'.
This change adds support to use the provided xAxisKey and yAxisKey values from the chartjs options object that is provided by the user.
Fall back to the original behavior in case these are not provided.
This is a non-breaking change.
Also, add the 'const' keyword in front of the addFilter method.