Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: matcher and parameter conditional compile for swift 3.1 #85

Merged
merged 1 commit into from Nov 21, 2017
Merged

fix: matcher and parameter conditional compile for swift 3.1 #85

merged 1 commit into from Nov 21, 2017

Conversation

amichnia
Copy link
Collaborator

Fixes inconsistency in handling different Swift versions. Main point of change is between Swift 3.2 and 3.1, where handling Sequence Element changed.

Should work under following setups:

  • Xcode 8.3 Swift 3.1 (lowest supported)
  • Xcode 8.3.3 Swift 3.1
  • Xcode 9, Swift 3.2 and 4.0+

@amichnia amichnia added the bug label Nov 21, 2017
@amichnia amichnia added this to To do in Version 1.0 fixes via automation Nov 21, 2017
@Przemyslaw-Wosko
Copy link
Member

#83

@amichnia amichnia mentioned this pull request Nov 21, 2017
Closed
@amichnia amichnia moved this from To do to Code review in Version 1.0 fixes Nov 21, 2017
@amichnia amichnia merged commit 3435a90 into MakeAWishFoundation:develop Nov 21, 2017
Version 1.0 fixes automation moved this from Code review to Done Nov 21, 2017
@amichnia amichnia deleted the hotfix/matcher-cases-for-swift-3.1 branch November 21, 2017 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Przemyslaw-Wosko Przemyslaw-Wosko Przemyslaw-Wosko approved these changes

Assignees

@amichnia amichnia

@Przemyslaw-Wosko Przemyslaw-Wosko

Labels
bug
Projects
No open projects
Version 1.0 fixes
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amichnia @Przemyslaw-Wosko