Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

docs(en): add selection sort #368

Merged
merged 7 commits into from
Jun 23, 2021
Merged

docs(en): add selection sort #368

merged 7 commits into from
Jun 23, 2021

Conversation

Sunainacode
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • New algorithm
  • Optimization in previous algorithms
  • Code style update
  • Refactor
  • Documentation
  • Other, please describe:

Briefly describe the changes in this PR

Added documentation for Selection Sort Algorithm
Other information:

@welcome
Copy link

welcome bot commented Jun 22, 2021

Thanks for opening this pull request! Please check out our contributing guidelines.

@ming-tsai
Copy link
Member

Hi @Sunainacode,
Please rewrite the steps and example sections, take the Bubble Sort as an example

The example section could be like this

Given array is
**13, 44, 5, 34, 3**

Sorted array is
**3, 5, 13, 34, 44**

**First pass**

Unsorted array: [13, 44, 5, 34, 3]

Minimum in an unsorted array: 3

Sorted array: [3]

**Second pass**

Unsorted array: [13, 44, 5, 34]

Minimum in unsorted array: 5

Sorted array: [3, 5]

**Third pass**

Unsorted array: [13, 44, 34]

Minimum in an unsorted array: 13

Sorted array: [3, 5, 13]

...

@ming-tsai ming-tsai changed the title Documentation for Selection Sort algorithm. docs(en): add selection Sort Jun 22, 2021
@ming-tsai ming-tsai changed the title docs(en): add selection Sort docs(en): add selection sort Jun 22, 2021
@ming-tsai ming-tsai self-requested a review June 22, 2021 22:25
@ming-tsai ming-tsai added the documentation Improvements or additions to documentation label Jun 22, 2021
@ming-tsai ming-tsai added this to In progress in documentation via automation Jun 22, 2021
@Sunainacode
Copy link
Contributor Author

Hi @ming-tsai.
Can you please review the changes now?

Co-authored-by: Ming Tsai <37890026+ming-tsai@users.noreply.github.com>
Copy link
Member

@ming-tsai ming-tsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Sunainacode

documentation automation moved this from In progress to Reviewer approved Jun 23, 2021
@ming-tsai ming-tsai merged commit 5d443c7 into MakeContributions:main Jun 23, 2021
documentation automation moved this from Reviewer approved to Done Jun 23, 2021
@welcome
Copy link

welcome bot commented Jun 23, 2021

Congrats on merging your first pull request! We here at MakeContributions are proud of you! 🎉🎉🎉🎉.
You are invited to be part of the team, the invitation link

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

Documentation for the algorithms
2 participants