Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp-based sort #10

Closed
wants to merge 2 commits into from
Closed

Conversation

CL-Jeremy
Copy link

First of all, thanks a lot for creating and updating this project.

This is a WIP that currently works fine if the user switches to classic view beforehand. It's a bit fragile for now. I do think adapting to the new design won't be that hard.

The reason I'm doing this is for sorting the posts by date, since the posts are not in chronological order.

TODO: swap .textContent with .innerHTML and manually apply regex fixes for cleaning to get rid of the "... view more" etc.

P. S.: I don't understand why ab stands for author so just swapped that with a single a. Do you mean "author (in bold)"?

@idilsaglam
Copy link
Collaborator

Thanks @CL-Jeremy really appreciate your contribution,

We're actually on a sort of a rush mode on a project, will check ASAP once the rush finishes.

Happy coding 🤓

@idilsaglam idilsaglam added enhancement New feature or request good first issue Good for newcomers labels Jun 30, 2020
@kaanyagci
Copy link
Contributor

Hi @CL-Jeremy, apologies for taking on this late. We'll look into it before the end of this week.

Just one thing AFAIK, the mobile site shows in chronological order and not the desktop site. For the mobile design part, you're right as we based on the mobile site. IDK if the design applies to it, but we will check this.

And as you guessed, the ab stands for bold author but swapping it is not a big problem.

@kaanyagci kaanyagci added this to To do in npm module May 20, 2021
src/index.js Show resolved Hide resolved
npm module automation moved this from To do to Review in progress May 27, 2021
@kaanyagci kaanyagci closed this May 30, 2021
npm module automation moved this from Review in progress to Done May 30, 2021
@kaanyagci
Copy link
Contributor

Closed due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants