Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use src(e) instead of e.src #80

Closed
CarloLucibello opened this issue May 21, 2022 · 1 comment · Fixed by #100
Closed

use src(e) instead of e.src #80

CarloLucibello opened this issue May 21, 2022 · 1 comment · Fixed by #100

Comments

@CarloLucibello
Copy link

Some code in the librariy, like this uses field access on edges, e.src, instead of the method src(e) which is what is required by Graphs.jl abstract graph interface.
As a result, graphplot(g) on custom graphs with custom edges can produce errors.
@hexaeder
Copy link
Collaborator

hexaeder commented May 22, 2022 •
edited

Good suggestion, I am happy to merge a PR that replaces all occurrences of .src and .dst :)

@visr visr mentioned this issue May 24, 2022
Closed
hdavid16 added a commit to hdavid16/GraphMakie.jl that referenced this issue Jan 21, 2023
@hdavid16
Close MakieOrg#80: use Graphs.jl API for edge src and dst
441691e
@hdavid16 hdavid16 mentioned this issue Jan 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Graphs.jl API to access src and dst of an edge hdavid16/GraphMakie.jl
2 participants
@CarloLucibello @hexaeder