linestyle improvements #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexaeder
force-pushed
the
hw/linestyles
branch
from
c51f49b
to
80455b5
Compare
lmshk
approved these changes
Nov 16, 2022
test/runtests.jl
Outdated
| DiGraph([Edge(1 => 2), Edge(2 => 3)]), | ||
| edge_attr = (; linestyle = [:dot, :dash]), | ||
| edge_plottype = :beziersegments, | ||
| ) |
There was a problem hiding this comment.
Maybe add one with curves just to be safe? ([Edge(1 => 2), Edge(2 => 1)] like above.)
Codecov ReportBase: 80.03% // Head: 80.28% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #94 +/- ##
==========================================
+ Coverage 80.03% 80.28% +0.24%
==========================================
Files 4 4
Lines 556 563 +7
==========================================
+ Hits 445 452 +7
Misses 111 111
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempt to close #93
I figured #93 has two parts:
linestyles<:Vectordoes not work forlinesegments. I don't like to automaticially usebeziersegmentsin that case. But the error explains that option now. I added a@test_brokenitem so hopefully we will notice if the corresponding makie issue gets resolved: Allow vector forlinestyleinlinesegmentsMakie.jl#1598linestyles<:Vector{Number}should not be split among edges if it happens to be the same length as the number of edges. I added a codepath to handle that case.