Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow colorrange as an attribute for Colorbar, which is consistent with plot types #1066

Merged
merged 2 commits into from Jul 10, 2021

Conversation

SimonDanisch
Copy link
Member

No description provided.

@jkrumbiegel
Copy link
Collaborator

In principle I don't mind this, but the current interface for colors / colormaps could be improved overall. Currently, we only support linear color lookup. You can of course transform the colormap but you lose the necessary precision and get banding issues etc. So instead of color plus colorrange, it would be better to pass colors as a sampler type directly, where array values and colormap go together with a possible scale function.

@SimonDanisch
Copy link
Member Author

Yeah, I've actually be wanting to do that for quite some time, and also get rid of the colormaps argument and always just use color, for anything color related...

@SimonDanisch
Copy link
Member Author

I'm going to merge this and opened this issue to later decide on a consistent name: #1106

@SimonDanisch SimonDanisch merged commit ecd1765 into master Jul 10, 2021
@SimonDanisch SimonDanisch deleted the sd/fix-Colorbar branch July 10, 2021 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants