workaround for 1 elem hists #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piever
reviewed
Aug 19, 2021
src/stats/hist.jl
Outdated
| @@ -72,6 +72,9 @@ function Makie.plot!(plot::Hist) | |||
| edges = lift(values, plot.bins) do vals, bins | |||
| if bins isa Int | |||
| mi, ma = float.(extrema(vals)) | |||
| if mi == ma | |||
| return nothing | |||
There was a problem hiding this comment.
Can't we just set
mi, ma = mi - 0.5, ma + 0.5 # EDIT: and maybe `bins = 1` to just get the one barand keep all the remaining logic the same? We still get the arbitrary bar of width 1 centered around the unique value, but avoid having to keep two different code paths.
In particular, I think having 2 separate code paths can cause issues with normalization options (for example with normalization = :pdf weights should be 1 instead of values[][1]).
There was a problem hiding this comment.
Good idea, thanks :)
SimonDanisch
changed the title
piever
reviewed
Aug 20, 2021
piever
approved these changes
Aug 20, 2021
Co-authored-by: Pietro Vertechi <pietro.vertechi@neuro.fchampalimaud.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hist([8,8,8,8,8])would yield histograms with nothing.With this PR, they get one bar at 8:
Not sure if it's the nicest way to set edges to nothing in that case, but since the edges are kind of undefined in that case, most other values would not work out?