Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added rotation arg for labels #1401

Merged
merged 3 commits into from Oct 28, 2021
Merged

added rotation arg for labels #1401

merged 3 commits into from Oct 28, 2021

Conversation

lazarusA
Copy link
Contributor

this allows to rotate barplot labels.

this allows to rotate the labels, if any, in the barplot recipe.
@ffreyer
Copy link
Collaborator

ffreyer commented Oct 23, 2021

I think "label_rotation" would be a better name because all the other input attributes are just "label_attribute".

@lazarusA
Copy link
Contributor Author

but, you also have
bar_labels = nothing
flip_labels_at

plus this also works for an array, i.e. a rotation for each label, hence labels_rotation. But, I'm happy with either as long as is available 😄, your call.

@jkrumbiegel
Copy link
Collaborator

I'm also for label_rotation

changed to `label_rotation`
@lazarusA
Copy link
Contributor Author

then label_rotation it is.

@SimonDanisch
Copy link
Member

Thanks!

@SimonDanisch SimonDanisch merged commit f3fc958 into MakieOrg:master Oct 28, 2021
@Flausi
Copy link

Flausi commented Apr 15, 2022

Hey, I think the rotation function is great, but I think at the same time you should be able to change the orientation/alignment. Maybe in the style of label_align = (:left, :center).

If the attribute is already there, sorry. :)
hist1

@jkrumbiegel
Copy link
Collaborator

The align can probably be made automatic for most cases following the logic of Axis ticklabels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants