New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update NEWS #1521
update NEWS #1521
Conversation
src/Makie.jl
Outdated
@@ -297,4 +297,6 @@ export heatmap!, image!, lines!, linesegments!, mesh!, meshscatter!, scatter!, s | |||
|
|||
export PointLight, EnvironmentLight, AmbientLight, SSAO | |||
|
|||
@deprecate Node Observable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only deprecates Node
as a function. Is there a way to deprecate it as a type (alias)? I.e. have foo(x::Node)
work with a deprecation warning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this will break any type signature using Node
with a weird error...
I thought about a way to deprecate a type gracefully, but I couldn't think of anything.
I think we should just remove the alias, and have people look at the change log when updating to a major version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also show a warning/info message with all breaking changes the first time someone compiles the new Makie version... I somehow don't like that approach, but I also can't find anything bad about it :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Base.@deprecate_binding
I removed the deprecation and added this PR & Release note to the NEWS to have a reference to all changes. |
Going to merge this... Let me know if there was anything missing! |
I went through all the pr's since the last version and tried to update NEWS.md with the more important changes. Since we are now about 50 pull requests ahead of the last version I thought it would be helpful to highlight a few bigger changes in a separate section. I also moved the current changes back under
## master
. Feel free to make changes to whatever needs them.Here's a list of all pull requests merged since 0.15.3. I marked the ones that are mentioned, added a pr number (without the hashtag to avoid pinging all of them) and added a note on what is affected (probably not entirely accurate).
add resize_to_layout!
[Makie]UndefVarError: not_implemented_for not defined
(1209) [Makie, MakieCore]