Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update NEWS #1521

Merged
merged 9 commits into from Dec 27, 2021
Merged

update NEWS #1521

merged 9 commits into from Dec 27, 2021

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Dec 18, 2021

I went through all the pr's since the last version and tried to update NEWS.md with the more important changes. Since we are now about 50 pull requests ahead of the last version I thought it would be helpful to highlight a few bigger changes in a separate section. I also moved the current changes back under ## master. Feel free to make changes to whatever needs them.

Here's a list of all pull requests merged since 0.15.3. I marked the ones that are mentioned, added a pr number (without the hashtag to avoid pinging all of them) and added a note on what is affected (probably not entirely accurate).

  • 1393 breaking release
    • 1192 cleanup scenes, boundingboxes, compile time latency [Makie]
    • 1222 logical expressions for ispressed (more programmable hotkeys) [Makie]
    • 1223 simplify plotting barplot by group [Makie]
    • 1307 Node -> Observable [All]
    • 1382 Add depth_shift (basically a fine grained overdraw) [GLMakie, WGLMakie]
    • 1392 fix order dependence of LScene and Axis (805) [Makie]
    • 1394 restrict Camera3D to last clicked/added scene (fixes scenes fighting over control) [Makie]
    • 1395 add depth to 3D contours and isosurfaces (i.e. allow other objects to intersect with them) [GLMakie]
  • 1413 add code of conduct [Pkg]
  • 1404 cleanup volumeslices (more control over attributes) [Makie]
  • 1411 cleanup menu render order & priority [Makie]
  • 1401 add rotation arg to labels in barplot [Makie]
  • 1408 improve latex docs [Docs]
  • 1260 allow lines of offsetarrays [Makie]
  • 1421 fix camera replacement [Makie]
  • 1438 add resize_to_layout! [Makie]
  • 1434 cleanup volume lighting [GLMakie, WGLMakie]
  • 1425 clarify plotting in REPL [Docs]
  • 1440 document dodge and dodge_gap [Docs]
  • 1446 fix set_theme! [Docs]
  • 1447 fix trimspine for n ticks < 2 and add example [Makie]
  • 1441 add aspect tutorial [Docs]
  • 1445 fix applyconvert [Makie]
  • 1452 disable rectangle zoom if we don't have inverse [Makie]
  • 1453 fix single point line bug [CairoMakie]
  • 1457 add lineheight and justification [Makie, Docs]
  • 1456 remove used attributes [Makie]
  • 1463 cycled color and automatic markercolor for scatterlines (fixes 1461 1306 1450) [Makie]
  • 1310 Add ECDF plot [Makie]
  • 1248 add Cycled object for direct cycler access [Makie]
  • 1473, 1475 Update colors.md [Docs]
  • 1477 Improve layout tutorial [Docs]
  • 1487 fix log ticklabels with very small or large exponents [Makie]
  • 1418 Order independent transparency [GLMakie]
  • 1439 update NEWS.md and prepare breaking release [All?]
  • 1494 Fix blurry text [GLMakie, WGLMakie]
  • 1488 error on colormap lookup with NaN, which should be handled elsewhere [Makie]
  • 1504 Disconnect other cameras when switching to PixelCamera [Makie]
  • 1448 Fix recipe docs [Docs]
  • 1423 Fix UndefVarError: not_implemented_for not defined (1209) [Makie, MakieCore]
  • 1481 start adding tests for primitives [Makie/Tests]
  • 1474 Create PULL_REQUEST_TEMPLATE.md [Pkg]
  • 1506 Make OIT less sensitive to avoid infinities (fix 1505) [Makie, GLMakie]
  • 1510 fix typo in port forwarding [Docs]
  • 1512 Remove redundant imports [All]
  • 1513 Fix occasional long ticks [Makie]
  • 1516 Default for DataInspector (use current_figure as default) [Makie]
  • 1499 Text layouting tests [Makie/Tests]
  • 1503 Fix remaining issues [All?]
    • change texture atlas font path, so users don't need to delete it manually
    • fix cairomakie 3d depth rendering issue
    • update new test images, make sure new basic tests pass on all backends
    • better unique test names, that are not depend on position in the file
  • 1518 Update volume() docstring [Docs]
  • 1435 bump compat for MathTeXEngine [REVERTED in 1489]
  • 1531 Typo in recipe docs [Docs]
  • 1526 Add documentation for attributes of primitive plots [Docs]
  • 1522 colormap documentation [Docs]
  • 1527 cleanup docs and last bug fixes [Docs, RPRMakie, Makie]
  • 1532 fix typo [Docs]
  • 1540 Some more clean ups [GLMakie]
  • 1545 Some fixes [GLMakie] (related to master)
  • 1549 make GLMakie.render less confusing [GLMakie]
  • 1547 Clarify remote servers page [Docs]
  • 1548 remove all mentions of node [Docs, Makie, MakieCore]
  • 1550 Mention and showoff z-order in transparency docs [Docs]
  • 1551 Prepare release [All?]

src/Makie.jl Outdated
@@ -297,4 +297,6 @@ export heatmap!, image!, lines!, linesegments!, mesh!, meshscatter!, scatter!, s

export PointLight, EnvironmentLight, AmbientLight, SSAO

@deprecate Node Observable
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only deprecates Node as a function. Is there a way to deprecate it as a type (alias)? I.e. have foo(x::Node) work with a deprecation warning?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this will break any type signature using Node with a weird error...
I thought about a way to deprecate a type gracefully, but I couldn't think of anything.
I think we should just remove the alias, and have people look at the change log when updating to a major version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also show a warning/info message with all breaking changes the first time someone compiles the new Makie version... I somehow don't like that approach, but I also can't find anything bad about it :D

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base.@deprecate_binding

@SimonDanisch
Copy link
Member

I removed the deprecation and added this PR & Release note to the NEWS to have a reference to all changes.
I think this is now mergeable :)

@SimonDanisch
Copy link
Member

Going to merge this... Let me know if there was anything missing!

@SimonDanisch SimonDanisch merged commit be1539f into master Dec 27, 2021
@SimonDanisch SimonDanisch deleted the ff/NEWS branch December 27, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants