Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in recipes docs #1531

Merged
merged 1 commit into from Dec 26, 2021
Merged

Typo in recipes docs #1531

merged 1 commit into from Dec 26, 2021

Conversation

Krastanov
Copy link
Contributor

Description

Fixes # (issue)

Add a description of your PR here.

Type of change

Delete options that do not apply:

  • Minor documentation typo
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@Krastanov
Copy link
Contributor Author

Maybe I am seriously misunderstanding the documentation, but this does not seem to work, nor is it the way core Makie creates its recipes, e.g. in https://github.com/JuliaPlots/Makie.jl/blob/8146f27ffa86d70a6aba786353ddc89f4d8b136d/src/stats/boxplot.jl#L34

The (presumably) incorrect docs confused me for the last half an hour. Hopefully this saves others from the same confusion :D

@SimonDanisch
Copy link
Member

Thanks, that's correct!

@SimonDanisch SimonDanisch merged commit 11f11c0 into MakieOrg:master Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants