Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the Cairo miter limit to mimic GLMakie #1844

Merged
merged 4 commits into from
May 3, 2022
Merged

Set the Cairo miter limit to mimic GLMakie #1844

merged 4 commits into from
May 3, 2022

Conversation

asinghvi17
Copy link
Member

@asinghvi17 asinghvi17 commented Apr 27, 2022 •
edited
Loading

Fixes #1843

Description

Fixes #1843

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)

@asinghvi17
Copy link
Member Author

asinghvi17 commented Apr 27, 2022 •
edited
Loading

ERROR: LoadError: LoadError: LoadError: LoadError: UndefVarError: @ccall not defined

ehhh...isn't this defined in base Julia? Plus it worked fine when eval'ing it in

@asinghvi17
Copy link
Member Author

asinghvi17 commented Apr 27, 2022 •
edited
Loading

Nevermind...the @ccall macro wasn't introduced until Julia 1.5. Will change it.

@asinghvi17 asinghvi17 mentioned this pull request Apr 28, 2022
Closed
@SimonDanisch SimonDanisch reopened this May 3, 2022
@SimonDanisch SimonDanisch merged commit e3b6560 into master May 3, 2022
@SimonDanisch SimonDanisch deleted the as/cairo_miter branch May 3, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonDanisch SimonDanisch Awaiting requested review from SimonDanisch

@jkrumbiegel jkrumbiegel Awaiting requested review from jkrumbiegel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Figure glitches CairoMakie backend
2 participants
@asinghvi17 @SimonDanisch