Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix manual cycling of attrs #1873

Merged
merged 4 commits into from May 5, 2022
Merged

fix manual cycling of attrs #1873

merged 4 commits into from May 5, 2022

Conversation

SimonDanisch
Copy link
Member

@SimonDanisch SimonDanisch commented May 3, 2022 •
edited

@SimonDanisch @rory-humphries
fix manual cycling of attrs
1875cb4 
Co-authored-by: Rory Humphries <rory@humphries.ie>
@SimonDanisch SimonDanisch mentioned this pull request May 3, 2022
Closed
1 task
jkrumbiegel
jkrumbiegel approved these changes May 5, 2022
View reviewed changes
Copy link
Collaborator

@jkrumbiegel jkrumbiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some small changes, rest is good to go.

@SimonDanisch SimonDanisch merged commit 06d2772 into master May 5, 2022
@SimonDanisch SimonDanisch deleted the sd/cycle-attributes branch May 5, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkrumbiegel jkrumbiegel jkrumbiegel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SimonDanisch @jkrumbiegel