Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (x/y)ticklabelaling #1882

Merged
merged 1 commit into from
May 5, 2022
Merged

fix (x/y)ticklabelaling #1882

merged 1 commit into from
May 5, 2022

Conversation

SimonDanisch
Copy link
Member

No description provided.

@asinghvi17
Copy link
Member

I think you might also have to change some corresponding code in LineAxis, possibly here:
https://github.com/JuliaPlots/Makie.jl/blob/1b70e3207b5367886af79508f4fa614045cd24ca/src/makielayout/lineaxis.jl#L149-L160

Since the axis side can be flipped, label alignment is determined within the LineAxis code. labelalign is not actually accessed in LineAxis.

@SimonDanisch
Copy link
Member Author

I think you might also have to change some corresponding code in LineAxis, possibly here:

No, I think this was just a regression in the type in Axis.

@asinghvi17
Copy link
Member

Oops...for some reason I read labelalign when it should have been ticklabelalign. My bad, sorry about that :D

@SimonDanisch SimonDanisch merged commit 4d84f8a into master May 5, 2022
@SimonDanisch SimonDanisch deleted the sd/xticklabelalign branch May 5, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkrumbiegel jkrumbiegel Awaiting requested review from jkrumbiegel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SimonDanisch @asinghvi17