Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrectly resolved merge conflict #1937

Merged
merged 1 commit into from May 13, 2022
Merged

fix incorrectly resolved merge conflict #1937

merged 1 commit into from May 13, 2022

Conversation

SimonDanisch
Copy link
Member

The PR changing the test infrastructure hasn't properly merged.

@SimonDanisch SimonDanisch merged commit 07f0763 into master May 13, 2022
@SimonDanisch SimonDanisch deleted the sd/fix-cci branch May 13, 2022 15:38
@MakieBot
Copy link
Collaborator

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt.

using time

master:  11.89 < 12.98 > 12.99, 0.42+-
pr:      12.22 < 12.75 > 13.17, 0.38+-
speedup: 0.90 < 1.00 > 1.06, 0.05+-
median:  -1.76% => invariant

This PR does not change the using time.

ttfp time

master   30.76 < 32.35 > 33.05, 0.89+-
pr       31.28 < 32.32 > 32.80, 0.60+-
speedup: 0.94 < 1.00 > 1.02, 0.03+-
median:  -0.08% => invariant

This PR does not change the ttfp time.

kunzaatko pushed a commit to kunzaatko/Makie.jl that referenced this pull request May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants