Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #1978 #1993

Merged
merged 3 commits into from
May 28, 2022
Merged

fix #1978 #1993

merged 3 commits into from
May 28, 2022

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented May 27, 2022 •
edited
Loading

Description

Fixes #1978

Type of change

Bug fix (non-breaking change which fixes an issue) (+ minor cleanup)

@MakieBot
Copy link
Collaborator

MakieBot commented May 27, 2022 •
edited
Loading

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt.

using time

master:  10.73 < 10.74 > 10.81, 0.03+-
pr:      10.71 < 10.75 > 10.78, 0.03+-
speedup: 1.00 < 1.00 > 1.01, 0.00+-
median:  +0.13% => invariant

This PR does not change the using time.

ttfp time

master   26.44 < 26.46 > 26.52, 0.03+-
pr       26.40 < 26.50 > 26.53, 0.05+-
speedup: 1.00 < 1.00 > 1.00, 0.00+-
median:  +0.12% => invariant

This PR does not change the ttfp time.

@ffreyer ffreyer merged commit 050525f into master May 28, 2022
@ffreyer ffreyer deleted the ff/interactions branch May 28, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkrumbiegel jkrumbiegel jkrumbiegel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

difference between pick(ax) and pick(fig)
3 participants
@ffreyer @MakieBot @jkrumbiegel