Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use max_methods and optlevel 0 where appropriate #2000

Merged
merged 1 commit into from May 30, 2022
Merged

Conversation

SimonDanisch
Copy link
Member

Split out from: #1968

@MakieBot
Copy link
Collaborator

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt.

using time

master:  13.79 < 13.95 > 14.22, 0.17+-
pr:      11.87 < 11.99 > 12.04, 0.06+-
speedup: 1.14 < 1.17 > 1.18, 0.01+-
median:  -14.01% => improvement

This PR improves the using time.

ttfp time

master   36.97 < 37.24 > 38.23, 0.44+-
pr       36.62 < 36.92 > 37.06, 0.15+-
speedup: 1.00 < 1.01 > 1.04, 0.01+-
median:  -0.86% => invariant

This PR does not change the ttfp time.

@SimonDanisch SimonDanisch merged commit b697b16 into master May 30, 2022
@SimonDanisch SimonDanisch deleted the sd/max-methods branch May 30, 2022 12:42
SimonDanisch added a commit that referenced this pull request May 30, 2022
* inferability + double notify improvements

* try max_methods

* bring back labeltext

* fix align + clean up

* turn closures into functions

* cleanup horizontal

* fix bugs, further improvements for axis

* clean up Experimental usage

* move max_methods into own pr (#2000)

* correct spelling mistake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants