Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix minor ticks #2027

Merged
merged 2 commits into from Jun 6, 2022
Merged

fix minor ticks #2027

merged 2 commits into from Jun 6, 2022

Conversation

SimonDanisch
Copy link
Member

#1968 broke minor ticks + grids:
image
This should fix it and add a reference image test for it.

@MakieBot
Copy link
Collaborator

MakieBot commented Jun 6, 2022

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt.

using time

master:  10.20 < 10.35 > 10.71, 0.21+-
pr:      10.19 < 10.31 > 10.49, 0.10+-
speedup: 0.98 < 1.00 > 1.05, 0.03+-
median:  -0.40% => invariant

This PR does not change the using time.

ttfp time

master   29.87 < 30.11 > 30.74, 0.30+-
pr       29.73 < 29.99 > 30.89, 0.40+-
speedup: 0.97 < 1.01 > 1.02, 0.02+-
median:  -0.39% => invariant

This PR does not change the ttfp time.

@jkrumbiegel
Copy link
Collaborator

I still have the feeling that there are double updates in there but I'm not motivated right now to go in again and check. Such a time sink

@SimonDanisch
Copy link
Member Author

Yeah, there still are definitely lots ^^ Lets pick this up again once we have a better idea of how we want to handle observables.

@SimonDanisch SimonDanisch merged commit 33751ef into master Jun 6, 2022
@SimonDanisch SimonDanisch deleted the sd/fix-sub-grid branch June 6, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants