Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix linked axis regression and add unit test #2039

Merged
merged 1 commit into from Jun 10, 2022
Merged

Conversation

jkrumbiegel
Copy link
Collaborator

@jkrumbiegel jkrumbiegel commented Jun 10, 2022

Not proliferating the targetlimits update when it got the same limits again broke the linkaxis functionality.

@MakieBot
Copy link
Collaborator

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt.

using time

master:  9.24 < 9.27 > 9.40, 0.05+-
pr:      9.23 < 9.26 > 9.41, 0.07+-
speedup: 0.98 < 1.00 > 1.02, 0.01+-
median:  -0.03% => invariant

This PR does not change the using time.

ttfp time

master   24.24 < 24.31 > 24.51, 0.09+-
pr       24.26 < 24.33 > 24.56, 0.11+-
speedup: 0.99 < 1.00 > 1.00, 0.00+-
median:  +0.09% => invariant

This PR does not change the ttfp time.

@jkrumbiegel jkrumbiegel merged commit d055f0c into master Jun 10, 2022
@jkrumbiegel jkrumbiegel deleted the jk/fix-targetlimits branch June 10, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants