Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't allow submit defocus on invalid textbox input #2041

Merged
merged 1 commit into from
Jun 11, 2022

Conversation

jkrumbiegel
Copy link
Member

@jkrumbiegel jkrumbiegel commented Jun 11, 2022

Description

Fixes #2037

On submitting an invalid textbox, the text shouldn't defocus which looks like submitting it worked.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)

@MakieBot
Copy link
Collaborator

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt.

using time

master:  9.10 < 9.15 > 9.20, 0.03+-
pr:      9.12 < 9.15 > 9.19, 0.03+-
speedup: 1.00 < 1.00 > 1.01, 0.00+-
median:  +0.10% => invariant

This PR does not change the using time.

ttfp time

master   24.24 < 24.29 > 24.57, 0.11+-
pr       24.28 < 24.38 > 24.44, 0.06+-
speedup: 0.99 < 1.00 > 1.01, 0.00+-
median:  +0.35% => invariant

This PR does not change the ttfp time.

@jkrumbiegel jkrumbiegel merged commit 16ff3eb into master Jun 11, 2022
@jkrumbiegel jkrumbiegel deleted the jk/invalid-textbox branch June 11, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Textbox errors depending on cursor position upon submission
2 participants