Cleanup stroke artifacts in scatter and text #2096
Conversation
ffreyer
changed the title
ffreyer
changed the title
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running: using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
|
|
Looks good to me, but could you add the example you posted in the PR as a test for this situation? |
|
I made a new version of the marker vs rotation test with stroke and glow. I also noticed that this sometimes creates some at the edges: (y, o, ...) The reason for this is texture bleed. Characters are encoded with signed distance fields, so the values in the texture represent the distance from the edge of a character, with positive numbers being outside. Stroke and glow basically draw between 0 distance and strokewidth/glowwidth. If opengl ends up interpolating between a positive value and a smaller value at the edge of the glyph texture, that region can become relevant for stroke and glow again. And that is what happens here because the texture is initialized to 0. Changing that to
|
|
I reduced the background value to Is there a way to force the texture atlas to get regenerated with the next tagged version? |
Missing reference imagesFound 1 new images without existing references. |
Missing reference imagesFound 2 new images without existing references. |
Missing reference imagesFound 2 new images without existing references. |
Missing reference imagesFound 2 new images without existing references. |
Missing reference imagesFound 2 new images without existing references. |
I guess I was too optimistic here. CairoMakie seems to stroke inwards and GLMakie outwards... (this is CairoMakie vs GLMakie) Edit: I was on the wrong branch |
|
I also tried an over operator for blending now, doesn't seem better to me |
Description
Using
strokwidth > 0in GLMakie with a non transparent (and non-background)colorcreates a thin outline around characters or makers in text and scatter.With text, white stroke and glow:
With scatter, stroke only:
The reason for this is that the blending uses a transparent version of
coloras the blend target for stroke. So the rgb component of thestrokecolorand thecolorget mixed at the edge, resulting in the artifacts seen above. The pr changes the reference color to be a transparent version ofstrokecolorat the outer edge, fixing this problem.After:
Type of change
Checklist