Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax align typing for Blocks #2108

Merged
merged 4 commits into from Jul 3, 2022
Merged

Relax align typing for Blocks #2108

merged 4 commits into from Jul 3, 2022

Conversation

jkrumbiegel
Copy link
Collaborator

Description

Fixes #1958 and fixes #2006

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added unit tests for new algorithms, conversion methods, etc.

@MakieBot
Copy link
Collaborator

MakieBot commented Jul 3, 2022

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 13.99s (12.85, 14.35) 0.52+- 24.34s (21.99, 25.21) 1.09+- 20.20s (18.59, 20.76) 0.73+- 22.65ms (20.50, 23.59) 1.00+- 89.23ms (86.40, 91.26) 1.86+-
master 13.43s (12.67, 14.28) 0.73+- 23.17s (21.95, 24.50) 1.18+- 20.18s (18.97, 21.19) 0.70+- 23.15ms (21.43, 24.71) 1.15+- 87.67ms (86.08, 91.00) 1.66+-
evaluation +4.01%, 0.56s invariant (0.89d, 0.13p, 0.62std) +4.82%, 1.17s invariant (1.03d, 0.08p, 1.14std) +0.07%, 0.01s invariant (0.02d, 0.97p, 0.72std) -2.21%, -0.5ms invariant (-0.47d, 0.40p, 1.08std) +1.75%, 1.57ms invariant (0.89d, 0.12p, 1.76std)
CairoMakie 13.46s (13.25, 13.93) 0.23+- 27.41s (27.21, 27.83) 0.21+- 4.07s (4.00, 4.15) 0.06+- 22.43ms (21.94, 22.86) 0.32+- 27.81ms (27.10, 28.58) 0.52+-
master 13.52s (13.23, 13.77) 0.20+- 27.55s (26.97, 28.36) 0.45+- 4.09s (3.93, 4.16) 0.08+- 22.68ms (22.13, 23.40) 0.48+- 28.33ms (27.51, 28.79) 0.44+-
evaluation -0.44%, -0.06s invariant (-0.27d, 0.62p, 0.22std) -0.53%, -0.14s invariant (-0.41d, 0.47p, 0.33std) -0.48%, -0.02s invariant (-0.28d, 0.62p, 0.07std) -1.13%, -0.25ms invariant (-0.62d, 0.27p, 0.40std) -1.86%, -0.52ms invariant (-1.07d, 0.07p, 0.48std)
WGLMakie 15.37s (14.16, 15.85) 0.56+- 33.04s (30.19, 34.37) 1.36+- 53.26s (52.19, 54.38) 0.81+- 23.61ms (22.69, 24.22) 0.55+- 1.81s (1.62, 2.77) 0.42+-
master 19.14s (14.33, 42.17) 10.17+- 36.74s (30.04, 59.39) 10.08+- 53.36s (51.61, 54.12) 0.84+- 24.35ms (21.63, 26.18) 1.39+- 1.62s (1.57, 1.66) 0.03+-
evaluation -24.48%, -3.76s noisy🤷‍♀️ (-0.52d, 0.37p, 5.37std) -11.21%, -3.7s noisy🤷‍♀️ (-0.52d, 0.37p, 5.72std) -0.19%, -0.1s invariant (-0.12d, 0.82p, 0.82std) -3.15%, -0.74ms invariant (-0.70d, 0.23p, 0.97std) +10.42%, 0.19s noisy🤷‍♀️ (0.63d, 0.28p, 0.23std)

@jkrumbiegel jkrumbiegel merged commit 3a17241 into master Jul 3, 2022
@jkrumbiegel jkrumbiegel deleted the jk/relax-align-typing branch July 3, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

axislegend cannot be positioned using a Tuple of numbers Axislegend fails when given a tuple of numbers
2 participants