Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Axis linking #2116

Merged
merged 3 commits into from
Jul 7, 2022
Merged

Fix Axis linking #2116

merged 3 commits into from
Jul 7, 2022

Conversation

jkrumbiegel
Copy link
Member

Description

Fixes #1718.

It wasn't checked correctly that if Axis A was linked to B, and then Axis B to C, that C should also be linked to A.

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@MakieBot
Copy link
Collaborator

MakieBot commented Jul 7, 2022

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 13.29s (13.14, 13.39) 0.09+- 23.89s (23.69, 24.15) 0.16+- 19.81s (19.61, 20.03) 0.15+- 19.80ms (19.64, 20.05) 0.13+- 82.58ms (82.05, 83.40) 0.52+-
master 13.26s (13.15, 13.42) 0.10+- 23.86s (23.71, 24.17) 0.16+- 19.71s (19.48, 19.88) 0.17+- 19.92ms (17.30, 20.58) 1.17+- 82.52ms (76.68, 84.21) 2.63+-
evaluation +0.26%, 0.03s invariant (0.36d, 0.51p, 0.09std) +0.15%, 0.04s invariant (0.23d, 0.67p, 0.16std) +0.49%, 0.1s invariant (0.63d, 0.27p, 0.16std) -0.61%, -0.12ms invariant (-0.15d, 0.79p, 0.65std) +0.08%, 0.07ms invariant (0.04d, 0.95p, 1.57std)
CairoMakie 13.56s (13.35, 13.84) 0.20+- 27.92s (27.53, 28.44) 0.34+- 4.06s (3.96, 4.15) 0.07+- 23.39ms (22.69, 23.96) 0.53+- 28.11ms (27.60, 29.07) 0.48+-
master 13.65s (13.36, 14.23) 0.30+- 27.60s (27.32, 28.03) 0.23+- 4.02s (3.94, 4.11) 0.05+- 23.27ms (22.39, 23.96) 0.52+- 28.10ms (27.56, 28.94) 0.54+-
evaluation -0.72%, -0.1s invariant (-0.38d, 0.49p, 0.25std) +1.13%, 0.31s invariant (1.09d, 0.07p, 0.28std) +0.91%, 0.04s invariant (0.63d, 0.26p, 0.06std) +0.51%, 0.12ms invariant (0.23d, 0.68p, 0.53std) +0.03%, 0.01ms invariant (0.02d, 0.97p, 0.51std)
WGLMakie 16.01s (15.60, 16.85) 0.54+- 35.50s (34.20, 37.23) 1.23+- 57.24s (56.01, 61.26) 1.82+- 26.41ms (26.08, 27.18) 0.37+- 1.85s (1.79, 1.93) 0.05+-
master 15.90s (15.52, 16.91) 0.49+- 35.07s (34.12, 37.39) 1.06+- 56.15s (54.55, 59.42) 1.59+- 26.50ms (25.55, 28.16) 0.79+- 1.81s (1.72, 1.90) 0.06+-
evaluation +0.70%, 0.11s invariant (0.22d, 0.69p, 0.51std) +1.22%, 0.43s invariant (0.38d, 0.49p, 1.15std) +1.91%, 1.1s invariant (0.64d, 0.25p, 1.70std) -0.33%, -0.09ms invariant (-0.14d, 0.80p, 0.58std) +1.96%, 0.04s invariant (0.64d, 0.26p, 0.06std)

@jkrumbiegel jkrumbiegel merged commit b288d64 into master Jul 7, 2022
@jkrumbiegel jkrumbiegel deleted the jk/fix-axis-linking branch July 7, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linkaxes! is asymmetric
2 participants