Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set gridlayoutbase compat to 0.9 #2135

Merged
merged 1 commit into from Jul 13, 2022
Merged

Conversation

jkrumbiegel
Copy link
Collaborator

Description

Fixes # (issue)

Add a description of your PR here.

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@MakieBot
Copy link
Collaborator

MakieBot commented Jul 13, 2022

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 16.93s (16.76, 17.03) 0.10+- 27.64s (27.37, 27.82) 0.18+- 23.76s (23.61, 24.03) 0.16+- 28.29ms (27.55, 29.70) 0.73+- 104.61ms (102.95, 107.34) 1.75+-
master 16.87s (16.63, 17.11) 0.16+- 27.49s (27.32, 27.66) 0.14+- 23.75s (23.55, 24.11) 0.19+- 27.61ms (26.90, 29.01) 0.69+- 103.46ms (101.86, 104.64) 0.99+-
evaluation +0.36%, 0.06s invariant (0.47d, 0.40p, 0.13std) +0.54%, 0.15s invariant (0.92d, 0.11p, 0.16std) +0.05%, 0.01s invariant (0.07d, 0.90p, 0.18std) +2.39%, 0.68ms invariant (0.95d, 0.10p, 0.71std) +1.10%, 1.15ms invariant (0.81d, 0.16p, 1.37std)
CairoMakie 12.04s (12.00, 12.06) 0.02+- 24.16s (24.00, 24.33) 0.10+- 3.61s (3.59, 3.64) 0.02+- 18.56ms (18.43, 18.76) 0.11+- 25.53ms (25.22, 25.81) 0.17+-
master 12.05s (12.01, 12.09) 0.02+- 23.91s (23.78, 24.04) 0.08+- 3.63s (3.60, 3.66) 0.02+- 18.39ms (18.26, 18.52) 0.11+- 25.51ms (25.09, 25.67) 0.19+-
evaluation -0.13%, -0.02s invariant (-0.72d, 0.21p, 0.02std) +1.02%, 0.25s slower X (2.62d, 0.00p, 0.09std) -0.47%, -0.02s invariant (-0.75d, 0.19p, 0.02std) +0.89%, 0.17ms slower X (1.53d, 0.01p, 0.11std) +0.11%, 0.03ms invariant (0.16d, 0.77p, 0.18std)
WGLMakie 14.91s (14.84, 15.03) 0.06+- 32.77s (32.57, 32.95) 0.14+- 51.53s (51.08, 53.13) 0.72+- 20.95ms (20.37, 21.62) 0.46+- 1.63s (1.56, 1.73) 0.05+-
master 14.99s (14.77, 15.81) 0.37+- 32.61s (32.40, 32.84) 0.15+- 51.19s (50.87, 51.48) 0.22+- 21.11ms (20.68, 21.57) 0.28+- 1.62s (1.60, 1.66) 0.03+-
evaluation -0.53%, -0.08s invariant (-0.30d, 0.60p, 0.22std) +0.50%, 0.16s invariant (1.13d, 0.06p, 0.14std) +0.66%, 0.34s invariant (0.64d, 0.27p, 0.47std) -0.75%, -0.16ms invariant (-0.41d, 0.46p, 0.37std) +0.71%, 0.01s invariant (0.28d, 0.61p, 0.04std)

@jkrumbiegel jkrumbiegel merged commit c18b242 into master Jul 13, 2022
@jkrumbiegel jkrumbiegel deleted the jk/bump-gridlayoutbase branch July 13, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants