Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gridlines (#2177) #2196

Merged
merged 1 commit into from
Aug 3, 2022
Merged

fix gridlines (#2177) #2196

merged 1 commit into from
Aug 3, 2022

Conversation

SimonDanisch
Copy link
Member

Forgot to add px_area also to minor grid lines when fixing the ticks...

@SimonDanisch SimonDanisch linked an issue Aug 3, 2022 that may be closed by this pull request
@MakieBot
Copy link
Collaborator

MakieBot commented Aug 3, 2022

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 17.66s (17.37, 17.89) 0.19+- 20.55s (20.35, 20.76) 0.16+- 16.90s (16.67, 17.03) 0.12+- 16.78ms (16.65, 16.89) 0.08+- 82.81ms (82.20, 83.39) 0.46+-
master 17.58s (17.42, 17.83) 0.14+- 20.59s (20.30, 20.77) 0.17+- 16.95s (16.72, 17.21) 0.15+- 16.90ms (16.54, 17.13) 0.23+- 82.82ms (81.43, 84.12) 0.90+-
evaluation +0.42%, 0.07s invariant (0.44d, 0.43p, 0.17std) -0.20%, -0.04s invariant (-0.25d, 0.65p, 0.17std) -0.25%, -0.04s invariant (-0.31d, 0.57p, 0.13std) -0.75%, -0.13ms invariant (-0.73d, 0.21p, 0.15std) -0.02%, -0.01ms invariant (-0.02d, 0.97p, 0.68std)
CairoMakie 16.37s (15.59, 16.85) 0.58+- 22.09s (20.95, 22.95) 0.90+- 2.74s (2.59, 2.85) 0.12+- 17.92ms (17.17, 18.72) 0.65+- 27.36ms (26.04, 28.29) 0.95+-
master 16.23s (15.46, 16.87) 0.55+- 21.85s (20.71, 22.92) 0.90+- 2.75s (2.57, 2.83) 0.10+- 17.70ms (16.76, 18.33) 0.56+- 27.86ms (25.90, 28.62) 0.91+-
evaluation +0.81%, 0.13s invariant (0.23d, 0.67p, 0.56std) +1.07%, 0.24s invariant (0.26d, 0.63p, 0.90std) -0.50%, -0.01s invariant (-0.12d, 0.82p, 0.11std) +1.22%, 0.22ms invariant (0.36d, 0.52p, 0.61std) -1.84%, -0.5ms invariant (-0.54d, 0.33p, 0.93std)
WGLMakie 19.93s (19.75, 20.15) 0.17+- 33.27s (32.78, 33.75) 0.41+- 44.76s (44.19, 45.96) 0.67+- 19.52ms (18.25, 20.08) 0.63+- 1.70s (1.68, 1.72) 0.02+-
master 19.84s (19.53, 20.08) 0.23+- 33.12s (32.65, 33.66) 0.42+- 44.47s (43.61, 45.29) 0.61+- 19.12ms (18.68, 19.40) 0.29+- 1.69s (1.64, 1.71) 0.02+-
evaluation +0.47%, 0.09s invariant (0.46d, 0.40p, 0.20std) +0.47%, 0.16s invariant (0.38d, 0.49p, 0.42std) +0.65%, 0.29s invariant (0.45d, 0.41p, 0.64std) +2.07%, 0.4ms invariant (0.83d, 0.16p, 0.46std) +0.34%, 0.01s invariant (0.27d, 0.62p, 0.02std)

@SimonDanisch SimonDanisch merged commit df9db82 into master Aug 3, 2022
@SimonDanisch SimonDanisch deleted the sd/fix-gridlines branch August 3, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overflowing minor grid, especially when adding limits
2 participants