Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broadcasting for linewidth, lengthscale & arrowsize #2273

Merged
merged 1 commit into from Sep 20, 2022

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Sep 14, 2022

Description

Fixes #2271, allowing for vector inputs of lengthscale, linewidth and arrowsize in 3D arrows. Basically just adding broadcast a few times.

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)

@MakieBot
Copy link
Collaborator

MakieBot commented Sep 14, 2022

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 19.18s (18.78, 19.90) 0.40+- 21.83s (21.33, 22.82) 0.64+- 20.17s (19.82, 20.81) 0.38+- 19.27ms (18.89, 19.95) 0.42+- 95.44ms (94.62, 96.27) 0.70+-
master 19.36s (18.77, 20.24) 0.62+- 22.14s (21.58, 22.76) 0.52+- 20.22s (19.73, 20.67) 0.36+- 19.64ms (18.95, 20.26) 0.49+- 96.05ms (93.58, 97.78) 1.63+-
evaluation -0.97%, -0.19s invariant (-0.35d, 0.52p, 0.51std) -1.40%, -0.3s invariant (-0.53d, 0.35p, 0.58std) -0.22%, -0.05s invariant (-0.12d, 0.82p, 0.37std) -1.91%, -0.37ms invariant (-0.81d, 0.16p, 0.45std) -0.64%, -0.61ms invariant (-0.49d, 0.39p, 1.16std)
CairoMakie 14.83s (13.91, 15.80) 0.70+- 20.64s (19.71, 22.17) 0.88+- 3.27s (3.11, 3.44) 0.13+- 18.51ms (17.66, 19.29) 0.56+- 27.43ms (26.32, 29.10) 0.94+-
master 14.65s (14.14, 15.44) 0.52+- 20.49s (19.69, 21.37) 0.59+- 3.28s (3.15, 3.49) 0.12+- 17.93ms (16.89, 19.32) 0.81+- 27.70ms (26.40, 29.68) 1.20+-
evaluation +1.20%, 0.18s invariant (0.29d, 0.60p, 0.61std) +0.73%, 0.15s invariant (0.20d, 0.72p, 0.73std) -0.42%, -0.01s invariant (-0.11d, 0.84p, 0.13std) +3.11%, 0.58ms invariant (0.83d, 0.15p, 0.68std) -0.98%, -0.27ms invariant (-0.25d, 0.65p, 1.07std)
WGLMakie 24.74s (23.95, 25.41) 0.48+- 36.14s (35.59, 36.50) 0.31+- 57.89s (57.24, 58.42) 0.46+- 32.66ms (31.95, 33.18) 0.47+- 2.01s (1.99, 2.05) 0.02+-
master 24.74s (24.22, 25.08) 0.31+- 36.20s (35.84, 36.48) 0.23+- 57.89s (57.18, 58.38) 0.39+- 32.81ms (32.21, 33.74) 0.57+- 2.02s (2.01, 2.05) 0.01+-
evaluation -0.01%, -0.0s invariant (-0.01d, 0.99p, 0.40std) -0.18%, -0.07s invariant (-0.24d, 0.66p, 0.27std) -0.01%, -0.0s invariant (-0.01d, 0.99p, 0.42std) -0.46%, -0.15ms invariant (-0.29d, 0.60p, 0.52std) -0.64%, -0.01s invariant (-0.82d, 0.15p, 0.02std)

@SimonDanisch SimonDanisch merged commit 16e4ece into master Sep 20, 2022
@SimonDanisch SimonDanisch deleted the ff/arrows branch September 20, 2022 12:31
@jkrumbiegel jkrumbiegel mentioned this pull request Oct 8, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3D arrows with variable thickness
3 participants