Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated Mat2f0 #2307

Merged
merged 1 commit into from
Sep 28, 2022
Merged

remove deprecated Mat2f0 #2307

merged 1 commit into from
Sep 28, 2022

Conversation

SimonDanisch
Copy link
Member

No description provided.

@MakieBot
Copy link
Collaborator

MakieBot commented Sep 28, 2022

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 21.49s (21.09, 22.10) 0.37+- 22.72s (22.25, 23.08) 0.32+- 21.37s (21.12, 21.64) 0.19+- 22.09ms (21.94, 22.33) 0.13+- 119.04ms (117.87, 121.21) 1.26+-
master 20.98s (20.56, 21.65) 0.37+- 22.77s (22.42, 23.02) 0.21+- 21.44s (21.11, 21.80) 0.27+- 21.73ms (21.31, 22.07) 0.25+- 119.06ms (116.07, 122.39) 2.00+-
evaluation +2.36%, 0.51s slower X (1.36d, 0.03p, 0.37std) -0.21%, -0.05s invariant (-0.17d, 0.75p, 0.27std) -0.36%, -0.08s invariant (-0.33d, 0.55p, 0.23std) +1.62%, 0.36ms slower X (1.83d, 0.01p, 0.19std) -0.02%, -0.03ms invariant (-0.02d, 0.98p, 1.63std)
CairoMakie 13.90s (13.35, 14.28) 0.35+- 18.93s (18.72, 19.22) 0.21+- 3.11s (3.05, 3.17) 0.04+- 17.02ms (16.63, 17.85) 0.44+- 25.67ms (25.22, 26.63) 0.47+-
master 13.84s (13.53, 14.27) 0.26+- 18.88s (18.47, 19.38) 0.35+- 3.15s (3.05, 3.25) 0.07+- 17.21ms (16.83, 18.56) 0.61+- 25.93ms (25.20, 26.32) 0.39+-
evaluation +0.41%, 0.06s invariant (0.18d, 0.74p, 0.31std) +0.23%, 0.04s invariant (0.15d, 0.78p, 0.28std) -1.10%, -0.03s invariant (-0.57d, 0.31p, 0.06std) -1.15%, -0.2ms invariant (-0.37d, 0.51p, 0.53std) -1.04%, -0.27ms invariant (-0.62d, 0.27p, 0.43std)
WGLMakie 24.66s (23.44, 25.31) 0.78+- 33.87s (32.27, 34.39) 0.78+- 55.33s (54.15, 56.20) 0.94+- 27.86ms (27.12, 28.77) 0.68+- 2.12s (2.08, 2.16) 0.02+-
master 24.70s (23.51, 25.23) 0.62+- 33.67s (32.24, 34.48) 0.76+- 55.45s (53.01, 56.56) 1.20+- 28.32ms (25.74, 29.51) 1.25+- 2.09s (2.05, 2.14) 0.03+-
evaluation -0.16%, -0.04s invariant (-0.05d, 0.92p, 0.70std) +0.60%, 0.2s invariant (0.27d, 0.63p, 0.77std) -0.22%, -0.12s invariant (-0.11d, 0.84p, 1.07std) -1.64%, -0.46ms invariant (-0.45d, 0.42p, 0.97std) +1.04%, 0.02s invariant (0.79d, 0.17p, 0.03std)

@SimonDanisch SimonDanisch merged commit b6e8b37 into master Sep 28, 2022
@SimonDanisch SimonDanisch deleted the sd/remove-dep-mat branch September 28, 2022 15:18
@jkrumbiegel jkrumbiegel mentioned this pull request Oct 8, 2022
5 tasks
t-bltg pushed a commit to t-bltg/Makie.jl that referenced this pull request Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants