Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invisible scenes #2317

Merged
merged 4 commits into from Oct 11, 2022
Merged

fix invisible scenes #2317

merged 4 commits into from Oct 11, 2022

Conversation

SimonDanisch
Copy link
Member

Fix for e.g. #2311

@MakieBot
Copy link
Collaborator

MakieBot commented Oct 5, 2022

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 17.14s (16.84, 17.79) 0.38+- 22.25s (21.79, 22.78) 0.32+- 20.46s (20.20, 20.85) 0.27+- 54.88ms (53.36, 55.52) 0.85+- 119.99ms (118.93, 121.06) 0.91+-
master 17.06s (16.58, 17.43) 0.34+- 22.35s (21.98, 22.72) 0.31+- 20.91s (20.46, 21.62) 0.41+- 54.97ms (54.00, 55.86) 0.78+- 119.10ms (117.91, 120.03) 0.72+-
evaluation +0.50%, 0.09s invariant (0.24d, 0.67p, 0.36std) -0.47%, -0.1s invariant (-0.33d, 0.54p, 0.31std) -2.19%, -0.45s faster ✓ (-1.28d, 0.04p, 0.34std) -0.16%, -0.09ms invariant (-0.11d, 0.84p, 0.82std) +0.74%, 0.89ms invariant (1.09d, 0.07p, 0.82std)
CairoMakie 13.95s (13.51, 14.45) 0.39+- 21.22s (20.14, 22.49) 1.01+- 3.37s (3.14, 3.59) 0.18+- 38.91ms (37.14, 40.99) 1.58+- 28.61ms (27.48, 29.63) 0.86+-
master 13.74s (13.32, 14.34) 0.44+- 20.84s (20.25, 21.76) 0.58+- 3.35s (3.19, 3.50) 0.11+- 38.17ms (36.91, 40.08) 1.09+- 28.55ms (27.69, 29.74) 0.69+-
evaluation +1.48%, 0.21s invariant (0.50d, 0.37p, 0.41std) +1.81%, 0.38s invariant (0.47d, 0.40p, 0.79std) +0.71%, 0.02s invariant (0.16d, 0.77p, 0.15std) +1.89%, 0.73ms invariant (0.54d, 0.33p, 1.34std) +0.22%, 0.06ms invariant (0.08d, 0.88p, 0.78std)
WGLMakie 12.02s (11.95, 12.15) 0.07+- 26.34s (26.20, 26.51) 0.12+- 41.55s (41.09, 43.50) 0.87+- 34.69ms (33.56, 36.52) 0.93+- 1.70s (1.63, 1.95) 0.11+-
master 12.12s (12.05, 12.18) 0.05+- 26.36s (26.25, 26.56) 0.11+- 41.27s (41.13, 41.56) 0.15+- 34.96ms (34.26, 35.60) 0.48+- 1.66s (1.65, 1.68) 0.01+-
evaluation -0.82%, -0.1s faster ✓ (-1.63d, 0.01p, 0.06std) -0.04%, -0.01s invariant (-0.10d, 0.86p, 0.11std) +0.66%, 0.27s invariant (0.44d, 0.44p, 0.51std) -0.77%, -0.27ms invariant (-0.36d, 0.52p, 0.71std) +2.34%, 0.04s invariant (0.49d, 0.39p, 0.06std)

@jkrumbiegel
Copy link
Collaborator

This needs a test like ax.blockscene.visible = false to check that it can be toggled and works for all backends.

@github-actions
Copy link
Contributor

Missing reference images

Found 1 new images without existing references.
Upload new reference images before merging this PR.

@github-actions
Copy link
Contributor

Missing reference images

Found 1 new images without existing references.
Upload new reference images before merging this PR.

@SimonDanisch SimonDanisch merged commit f992b02 into master Oct 11, 2022
@SimonDanisch SimonDanisch deleted the sd/invisible-scenes branch October 11, 2022 10:31
@rafaqz
Copy link
Contributor

rafaqz commented Oct 11, 2022

This is amazing, thanks for adding it so quickly.

t-bltg pushed a commit to t-bltg/Makie.jl that referenced this pull request Dec 31, 2022
* fix invisible scenes

* add test

* fix other backends
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants