Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix picking warning and update_axis_camera #2352

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Conversation

SimonDanisch
Copy link
Member

If update_axis_camera is fed with heterogenous input types (like e.g. in GeoMakie), this errors without Float32.

@MakieBot
Copy link
Collaborator

MakieBot commented Oct 21, 2022

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 29.70s (29.40, 30.14) 0.24+- 18.73s (18.49, 19.01) 0.17+- 16.68s (16.47, 17.07) 0.19+- 16.52ms (16.28, 16.86) 0.23+- 48.80ms (47.78, 49.86) 0.64+-
master 29.88s (29.66, 30.37) 0.24+- 18.68s (18.52, 18.89) 0.14+- 16.61s (16.46, 16.79) 0.13+- 16.62ms (16.46, 16.81) 0.13+- 49.60ms (47.77, 52.23) 1.46+-
evaluation -0.60%, -0.18s invariant (-0.75d, 0.18p, 0.24std) +0.29%, 0.06s invariant (0.36d, 0.52p, 0.15std) +0.42%, 0.07s invariant (0.42d, 0.44p, 0.16std) -0.58%, -0.1ms invariant (-0.51d, 0.36p, 0.18std) -1.63%, -0.8ms invariant (-0.71d, 0.22p, 1.05std)
CairoMakie 26.59s (26.37, 26.81) 0.14+- 19.18s (18.72, 19.51) 0.29+- 2.74s (2.69, 2.79) 0.04+- 16.90ms (16.60, 17.20) 0.23+- 24.06ms (23.53, 24.40) 0.29+-
master 26.05s (25.83, 26.28) 0.16+- 19.11s (18.76, 19.33) 0.22+- 2.72s (2.68, 2.75) 0.03+- 17.08ms (16.65, 17.40) 0.24+- 24.12ms (23.74, 24.44) 0.29+-
evaluation +2.02%, 0.54s slower X (3.47d, 0.00p, 0.15std) +0.35%, 0.07s invariant (0.26d, 0.63p, 0.25std) +0.91%, 0.02s invariant (0.69d, 0.22p, 0.04std) -1.04%, -0.18ms invariant (-0.75d, 0.19p, 0.23std) -0.24%, -0.06ms invariant (-0.20d, 0.71p, 0.29std)
WGLMakie 42.43s (41.32, 43.62) 0.91+- 39.10s (38.14, 40.92) 1.06+- 60.02s (58.49, 63.39) 1.82+- 43.41ms (39.17, 46.46) 2.70+- 137.52ms (128.50, 160.33) 10.91+-
master 42.99s (40.45, 44.73) 1.42+- 39.53s (37.51, 40.82) 1.09+- 59.58s (57.18, 61.78) 1.73+- 34.59ms (32.83, 35.96) 1.07+- 114.16ms (103.32, 126.84) 9.39+-
evaluation -1.32%, -0.56s invariant (-0.47d, 0.40p, 1.17std) -1.11%, -0.43s invariant (-0.40d, 0.46p, 1.07std) +0.73%, 0.44s invariant (0.25d, 0.65p, 1.77std) +20.32%, 8.82ms slower❌ (4.30d, 0.00p, 1.88std) +16.99%, 23.36ms slower❌ (2.29d, 0.00p, 10.15std)

@SimonDanisch SimonDanisch merged commit c8a36f3 into master Oct 21, 2022
@SimonDanisch SimonDanisch deleted the sd/fix-pick-warning branch October 21, 2022 17:02
t-bltg pushed a commit to t-bltg/Makie.jl that referenced this pull request Dec 31, 2022
* fix picking warning for WGLMakie

* preserve type for heterogenous input types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants