bring back inline! :(

[SimonDanisch]

Guess we couldn't remove it yet, because I forgot the edge case of VSCode repl exposing a plotpane, but directly calling display(eval_result), which made Makie@0.18 always open a window, without a way to switch that behaviour.

We really want a better solution, especially since inline!(false) doesn't currently always open a window, since we can't figure out how to always open a window, when VSCode thinks everything should go into the plotpane ;)
Fixes #2331

[jkrumbiegel]

I guess we could also call it force_inline! so that the negation doesn't promise a window. On the other hand, why introduce new syntax just to remove it again soon-ish.

[SimonDanisch]

I don't want to rename it, since I really don't want to keep this solution in the future. Renaming the stopgap solution would be too much code churn for my taste ;)

[jkrumbiegel]

Yeah I figured, I agree

[MakieBot]

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))

	using	create	display	create	display
GLMakie	32.16s (31.74, 32.28) 0.19+-	18.86s (18.69, 19.15) 0.16+-	16.84s (16.65, 17.08) 0.18+-	18.29ms (17.99, 18.67) 0.22+-	51.67ms (50.83, 52.25) 0.47+-
master	32.44s (32.20, 32.71) 0.19+-	18.67s (18.41, 18.96) 0.21+-	16.67s (16.35, 16.98) 0.19+-	18.08ms (17.71, 18.60) 0.29+-	51.12ms (50.79, 51.70) 0.33+-
evaluation	-0.89%, -0.29s faster ✓ (-1.50d, 0.02p, 0.19std)	+1.00%, 0.19s invariant (1.01d, 0.09p, 0.18std)	+0.97%, 0.16s invariant (0.88d, 0.13p, 0.18std)	+1.20%, 0.22ms invariant (0.86d, 0.14p, 0.25std)	+1.07%, 0.55ms slower X (1.36d, 0.03p, 0.40std)
CairoMakie	27.34s (27.19, 27.86) 0.23+-	18.36s (18.03, 18.65) 0.23+-	2.60s (2.55, 2.64) 0.04+-	17.68ms (17.32, 18.03) 0.25+-	22.81ms (22.72, 22.97) 0.08+-
master	27.17s (27.08, 27.27) 0.07+-	18.38s (17.97, 18.53) 0.19+-	2.64s (2.60, 2.67) 0.02+-	18.08ms (17.98, 18.22) 0.09+-	22.86ms (22.76, 22.96) 0.08+-
evaluation	+0.60%, 0.16s invariant (0.95d, 0.12p, 0.15std)	-0.11%, -0.02s invariant (-0.10d, 0.86p, 0.21std)	-1.76%, -0.05s faster ✓ (-1.53d, 0.02p, 0.03std)	-2.30%, -0.41ms faster ✓ (-2.14d, 0.00p, 0.17std)	-0.21%, -0.05ms invariant (-0.58d, 0.30p, 0.08std)
WGLMakie	43.93s (42.21, 44.55) 0.81+-	38.93s (37.39, 39.94) 0.88+-	58.20s (55.69, 60.53) 1.65+-	48.00ms (44.51, 51.28) 2.26+-	145.72ms (123.95, 168.49) 14.66+-
master	43.76s (43.40, 44.52) 0.38+-	38.45s (37.38, 40.34) 1.14+-	60.02s (58.43, 63.11) 1.51+-	37.71ms (37.01, 38.49) 0.49+-	115.67ms (101.05, 127.65) 10.93+-
evaluation	+0.39%, 0.17s invariant (0.27d, 0.63p, 0.60std)	+1.23%, 0.48s invariant (0.47d, 0.40p, 1.01std)	-3.12%, -1.81s invariant (-1.14d, 0.05p, 1.58std)	+21.43%, 10.28ms slower❌ (6.30d, 0.00p, 1.37std)	+20.62%, 30.05ms slower❌ (2.32d, 0.00p, 12.79std)