Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Axis3 tick flipping with negative azimuth #2364

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Conversation

jkrumbiegel
Copy link
Member

No description provided.

@MakieBot
Copy link
Collaborator

MakieBot commented Oct 25, 2022

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 34.47s (34.08, 35.07) 0.39+- 20.44s (20.02, 20.99) 0.37+- 18.23s (18.05, 18.44) 0.14+- 19.79ms (19.61, 19.92) 0.12+- 55.78ms (55.23, 56.88) 0.53+-
master 34.91s (34.59, 35.28) 0.29+- 20.23s (20.14, 20.36) 0.09+- 18.16s (17.92, 18.61) 0.22+- 20.19ms (19.63, 21.21) 0.52+- 56.61ms (55.22, 59.38) 1.32+-
evaluation -1.26%, -0.44s faster ✓ (-1.26d, 0.04p, 0.34std) +1.06%, 0.22s invariant (0.81d, 0.18p, 0.23std) +0.38%, 0.07s invariant (0.38d, 0.49p, 0.18std) -2.03%, -0.4ms invariant (-1.07d, 0.09p, 0.32std) -1.48%, -0.82ms invariant (-0.82d, 0.16p, 0.93std)
CairoMakie 31.63s (31.46, 31.87) 0.16+- 22.47s (22.20, 22.80) 0.24+- 3.21s (3.17, 3.25) 0.03+- 23.75ms (23.11, 24.17) 0.43+- 27.38ms (27.05, 27.78) 0.27+-
master 31.80s (31.46, 32.08) 0.21+- 22.35s (21.57, 22.74) 0.39+- 3.22s (3.14, 3.30) 0.05+- 23.59ms (22.99, 24.27) 0.45+- 27.36ms (26.72, 27.95) 0.43+-
evaluation -0.52%, -0.17s invariant (-0.89d, 0.12p, 0.18std) +0.57%, 0.13s invariant (0.40d, 0.47p, 0.31std) -0.29%, -0.01s invariant (-0.24d, 0.66p, 0.04std) +0.66%, 0.16ms invariant (0.36d, 0.52p, 0.44std) +0.08%, 0.02ms invariant (0.06d, 0.91p, 0.35std)
WGLMakie 38.75s (37.94, 39.76) 0.69+- 34.16s (33.92, 34.78) 0.31+- 50.99s (50.37, 52.88) 0.87+- 34.98ms (33.14, 36.54) 1.23+- 125.83ms (117.50, 138.97) 7.08+-
master 38.63s (38.35, 39.25) 0.30+- 34.11s (33.75, 34.65) 0.33+- 50.89s (50.19, 51.65) 0.52+- 27.69ms (27.22, 28.49) 0.53+- 105.10ms (95.87, 119.07) 7.70+-
evaluation +0.31%, 0.12s invariant (0.23d, 0.68p, 0.49std) +0.15%, 0.05s invariant (0.16d, 0.76p, 0.32std) +0.19%, 0.1s invariant (0.13d, 0.81p, 0.70std) +20.83%, 7.29ms slower❌ (7.66d, 0.00p, 0.88std) +16.48%, 20.73ms slower❌ (2.80d, 0.00p, 7.39std)

@jkrumbiegel jkrumbiegel merged commit 10e3bb0 into master Oct 25, 2022
@jkrumbiegel jkrumbiegel deleted the jk/fix-ax3-azimuth branch October 25, 2022 09:41
t-bltg pushed a commit to t-bltg/Makie.jl that referenced this pull request Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants