Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were freeing the camera observables when freeing the
renderobject
from a plot, which happened since e.g. wasrenderobject[:resolution] === scene.camera.resolution
. Solution is to pass a copy of the camera observables which where passed directly.Other attributes should be fine, since we lift + convert them.
I hope to figure out a real, general solution to cleaner clean ups in #2372.