Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2369 #2375

Merged
merged 1 commit into from Oct 26, 2022
Merged

fix #2369 #2375

merged 1 commit into from Oct 26, 2022

Conversation

SimonDanisch
Copy link
Member

The (unnecessary) convert wrongfully took away the observable powers from color...

@SimonDanisch SimonDanisch linked an issue Oct 26, 2022 that may be closed by this pull request
@MakieBot
Copy link
Collaborator

MakieBot commented Oct 26, 2022

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 29.79s (29.69, 29.91) 0.09+- 18.69s (18.62, 18.78) 0.06+- 16.75s (16.65, 16.94) 0.10+- 16.72ms (16.46, 16.96) 0.17+- 49.11ms (48.29, 51.20) 1.00+-
master 29.84s (29.65, 30.20) 0.21+- 18.76s (18.64, 18.88) 0.08+- 16.71s (16.69, 16.75) 0.02+- 16.70ms (16.49, 16.86) 0.13+- 48.95ms (48.17, 50.42) 0.75+-
evaluation -0.18%, -0.05s invariant (-0.33d, 0.56p, 0.15std) -0.35%, -0.06s invariant (-0.97d, 0.10p, 0.07std) +0.21%, 0.03s invariant (0.50d, 0.39p, 0.06std) +0.15%, 0.03ms invariant (0.17d, 0.76p, 0.15std) +0.32%, 0.16ms invariant (0.18d, 0.74p, 0.88std)
CairoMakie 27.85s (27.64, 27.99) 0.14+- 18.80s (18.71, 18.92) 0.07+- 2.73s (2.66, 2.86) 0.06+- 18.36ms (18.08, 18.63) 0.18+- 22.96ms (22.82, 23.06) 0.09+-
master 28.00s (27.83, 28.14) 0.12+- 18.85s (18.71, 18.90) 0.06+- 2.69s (2.66, 2.73) 0.03+- 18.37ms (18.08, 18.90) 0.26+- 23.04ms (22.96, 23.10) 0.05+-
evaluation -0.52%, -0.14s invariant (-1.10d, 0.06p, 0.13std) -0.31%, -0.06s invariant (-0.90d, 0.12p, 0.06std) +1.37%, 0.04s invariant (0.79d, 0.18p, 0.04std) -0.03%, -0.01ms invariant (-0.02d, 0.96p, 0.22std) -0.36%, -0.08ms invariant (-1.19d, 0.05p, 0.07std)
WGLMakie 33.62s (33.29, 33.74) 0.15+- 28.95s (28.64, 29.18) 0.19+- 43.04s (42.60, 43.90) 0.43+- 23.92ms (23.36, 25.05) 0.55+- 118.17ms (114.09, 132.32) 6.66+-
master 33.80s (33.68, 34.04) 0.12+- 29.01s (28.48, 29.14) 0.23+- 43.80s (43.28, 45.40) 0.74+- 23.05ms (22.50, 23.87) 0.47+- 80.42ms (72.70, 88.35) 5.38+-
evaluation -0.54%, -0.18s faster ✓ (-1.30d, 0.03p, 0.14std) -0.23%, -0.07s invariant (-0.31d, 0.58p, 0.21std) -1.74%, -0.75s faster ✓ (-1.24d, 0.04p, 0.59std) +3.63%, 0.87ms slower X (1.70d, 0.01p, 0.51std) +31.94%, 37.75ms slower❌ (6.24d, 0.00p, 6.02std)

@SimonDanisch SimonDanisch merged commit 4b586a9 into master Oct 26, 2022
@SimonDanisch SimonDanisch deleted the sd/fix-color-updates branch October 26, 2022 13:05
t-bltg pushed a commit to t-bltg/Makie.jl that referenced this pull request Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

meshscatter color doesn't update with WGLMakie
2 participants