changes to GLMakie to get drawing into a GtkGLArea working #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ignore a certain GLFW error when calling set_parameters() on a Texture - in postprocessing, optionally call glBindFramebuffer with a non-zero ID
t-bltg
pushed a commit
to t-bltg/Makie.jl
that referenced
this pull request
Dec 31, 2022
…2418) - ignore a certain GLFW error when calling set_parameters() on a Texture - in postprocessing, optionally call glBindFramebuffer with a non-zero ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm working with @SimonDanisch to get GLMakie to draw into a Gtk4 window. This branch has a couple of changes that I had to make to GLMakie to get a plot to appear.
Here I just added a try/catch to ignore that error. There's probably a more correct approach.
https://stackoverflow.com/questions/62422683/framebuffer-issue-render-to-texture-with-gtk3-glarea-vs-glfw-identical-opengl
In to_screen_postprocessor(), I added an argument that lets you set default_ID. The default is 0, so GLMakie works fine, but in my code I've hard coded this to 2, which works on my laptop. It would be better to query this number at the beginning of rendering. I suspect if we try to have multiple windows this will become important.
Type of change