Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new JSServe #2428

Merged
merged 71 commits into from
Dec 30, 2022
Merged

Use new JSServe #2428

merged 71 commits into from
Dec 30, 2022

Conversation

SimonDanisch
Copy link
Member

No description provided.

@MakieBot
Copy link
Collaborator

MakieBot commented Nov 17, 2022

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 31.72s (31.36, 32.00) 0.20+- 16.06s (15.76, 16.39) 0.27+- 14.85s (14.56, 15.22) 0.26+- 11.36ms (11.20, 11.72) 0.18+- 133.76ms (130.28, 135.95) 2.15+-
master 31.68s (31.38, 31.97) 0.21+- 15.97s (15.84, 16.27) 0.14+- 14.69s (14.57, 15.02) 0.15+- 11.43ms (11.27, 11.52) 0.09+- 134.66ms (132.88, 136.82) 1.47+-
evaluation +0.13%, 0.04s invariant (0.21d, 0.71p, 0.21std) +0.58%, 0.09s invariant (0.43d, 0.44p, 0.20std) +1.05%, 0.16s invariant (0.72d, 0.21p, 0.21std) -0.67%, -0.08ms invariant (-0.53d, 0.35p, 0.13std) -0.67%, -0.89ms invariant (-0.48d, 0.39p, 1.81std)
CairoMakie 31.86s (31.57, 32.21) 0.23+- 19.86s (19.66, 20.20) 0.19+- 3.01s (2.97, 3.09) 0.04+- 13.59ms (13.41, 13.86) 0.16+- 5.46ms (5.30, 5.65) 0.13+-
master 32.03s (31.70, 32.31) 0.20+- 20.03s (19.79, 20.35) 0.23+- 3.05s (3.01, 3.11) 0.04+- 13.44ms (13.22, 13.66) 0.14+- 5.45ms (5.27, 5.72) 0.17+-
evaluation -0.51%, -0.16s invariant (-0.75d, 0.19p, 0.22std) -0.90%, -0.18s invariant (-0.84d, 0.14p, 0.21std) -1.09%, -0.03s invariant (-0.86d, 0.13p, 0.04std) +1.10%, 0.15ms invariant (0.98d, 0.09p, 0.15std) +0.11%, 0.01ms invariant (0.04d, 0.94p, 0.15std)
WGLMakie 37.30s (36.49, 39.13) 0.95+- 15.71s (15.28, 16.28) 0.38+- 24.50s (24.03, 25.61) 0.54+- 15.75ms (14.81, 17.34) 1.08+- 2.37s (2.14, 2.57) 0.14+-
master 37.27s (36.06, 40.20) 1.53+- 18.10s (16.83, 19.22) 0.92+- 51.10s (29.11, 168.89) 51.97+- 15.21ms (13.59, 18.24) 1.68+- 2.82s (2.75, 2.94) 0.07+-
evaluation +0.07%, 0.02s invariant (0.02d, 0.97p, 1.24std) -15.25%, -2.4s faster✅ (-3.39d, 0.00p, 0.65std) -108.54%, -26.6s noisy🤷‍♀️ (-0.72d, 0.22p, 26.26std) +3.41%, 0.54ms invariant (0.38d, 0.49p, 1.38std) -19.22%, -0.45s faster✅ (-4.11d, 0.00p, 0.10std)

@github-actions
Copy link
Contributor

Missing reference images

Found 1 new images without existing references.
Upload new reference images before merging this PR.

@SimonDanisch
Copy link
Member Author

SimonDanisch commented Dec 29, 2022

Will close:
#2483
#2358
#2243
#2147
#1877
#1711
#1546
#1542
#1346
#1337
#1202
#1136
#1135
#1396
#1136
#2204
#1498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants