Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hvlines for GLMakie #2446

Merged
merged 3 commits into from Nov 25, 2022
Merged

fix hvlines for GLMakie #2446

merged 3 commits into from Nov 25, 2022

Conversation

SimonDanisch
Copy link
Member

@SimonDanisch SimonDanisch commented Nov 25, 2022

@MakieBot
Copy link
Collaborator

MakieBot commented Nov 25, 2022

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 32.00s (31.89, 32.20) 0.11+- 19.38s (19.09, 19.84) 0.29+- 18.23s (17.94, 18.99) 0.39+- 14.81ms (14.57, 14.99) 0.15+- 149.46ms (144.06, 152.58) 2.63+-
master 31.66s (31.40, 32.47) 0.40+- 19.24s (19.00, 19.90) 0.30+- 18.14s (17.90, 18.97) 0.38+- 14.84ms (14.66, 15.28) 0.20+- 152.55ms (148.38, 156.52) 2.81+-
evaluation +1.05%, 0.34s invariant (1.16d, 0.07p, 0.25std) +0.68%, 0.13s invariant (0.45d, 0.42p, 0.30std) +0.49%, 0.09s invariant (0.23d, 0.68p, 0.39std) -0.20%, -0.03ms invariant (-0.17d, 0.76p, 0.18std) -2.07%, -3.1ms invariant (-1.14d, 0.05p, 2.72std)
CairoMakie 25.05s (24.93, 25.12) 0.07+- 17.42s (17.29, 17.68) 0.13+- 2.49s (2.48, 2.51) 0.01+- 12.70ms (12.67, 12.76) 0.03+- 4.35ms (4.17, 4.57) 0.14+-
master 24.67s (24.49, 24.76) 0.09+- 17.46s (17.36, 17.54) 0.07+- 2.53s (2.50, 2.56) 0.02+- 12.63ms (12.49, 12.71) 0.07+- 4.27ms (4.19, 4.37) 0.07+-
evaluation +1.52%, 0.38s slower X (4.82d, 0.00p, 0.08std) -0.24%, -0.04s invariant (-0.40d, 0.47p, 0.10std) -1.34%, -0.03s faster ✓ (-1.84d, 0.01p, 0.02std) +0.58%, 0.07ms slower X (1.41d, 0.03p, 0.05std) +1.97%, 0.09ms invariant (0.79d, 0.17p, 0.10std)
WGLMakie 33.54s (33.17, 33.84) 0.24+- 26.68s (26.22, 26.86) 0.22+- 44.12s (43.47, 44.74) 0.40+- 17.85ms (17.19, 18.24) 0.36+- 1.92s (1.89, 1.93) 0.02+-
master 33.39s (33.24, 33.72) 0.15+- 26.57s (26.15, 26.93) 0.28+- 43.88s (43.22, 44.69) 0.57+- 17.83ms (17.19, 18.10) 0.32+- 1.70s (1.68, 1.75) 0.03+-
evaluation +0.43%, 0.14s invariant (0.73d, 0.20p, 0.19std) +0.40%, 0.11s invariant (0.41d, 0.45p, 0.25std) +0.55%, 0.24s invariant (0.50d, 0.37p, 0.48std) +0.12%, 0.02ms invariant (0.06d, 0.91p, 0.34std) +11.02%, 0.21s slower❌ (9.57d, 0.00p, 0.02std)

@SimonDanisch SimonDanisch merged commit 02b5c39 into master Nov 25, 2022
@SimonDanisch SimonDanisch deleted the sd/fix-only-hvlines branch November 25, 2022 22:59
t-bltg pushed a commit to t-bltg/Makie.jl that referenced this pull request Dec 31, 2022
* fix hvlines for GLMakie

* add extract_keys utility

* fix vlines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants