Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode paths for default fonts to avoid search latency #2531

Merged
merged 1 commit into from Dec 28, 2022

Conversation

jkrumbiegel
Copy link
Collaborator

Description

Fixes #2528

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)

@MakieBot
Copy link
Collaborator

MakieBot commented Dec 28, 2022

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 32.07s (31.80, 32.30) 0.18+- 16.62s (16.47, 16.82) 0.12+- 15.45s (15.37, 15.54) 0.06+- 11.56ms (11.46, 11.74) 0.09+- 136.56ms (133.68, 138.36) 1.54+-
master 31.93s (31.61, 32.07) 0.17+- 16.71s (16.59, 16.89) 0.10+- 15.46s (15.28, 15.58) 0.10+- 11.75ms (11.62, 11.93) 0.11+- 136.54ms (131.90, 138.75) 2.23+-
evaluation +0.43%, 0.14s invariant (0.78d, 0.17p, 0.17std) -0.59%, -0.1s invariant (-0.89d, 0.12p, 0.11std) -0.07%, -0.01s invariant (-0.12d, 0.82p, 0.08std) -1.60%, -0.19ms faster ✓ (-1.82d, 0.01p, 0.10std) +0.01%, 0.02ms invariant (0.01d, 0.99p, 1.89std)
CairoMakie 26.35s (26.22, 26.45) 0.08+- 16.23s (16.07, 16.34) 0.09+- 2.52s (2.50, 2.54) 0.01+- 10.56ms (10.45, 10.62) 0.07+- 4.20ms (4.09, 4.27) 0.07+-
master 26.29s (26.26, 26.38) 0.04+- 16.17s (16.11, 16.21) 0.03+- 2.51s (2.50, 2.52) 0.01+- 10.56ms (10.55, 10.58) 0.01+- 4.14ms (4.09, 4.17) 0.03+-
evaluation +0.23%, 0.06s invariant (0.92d, 0.12p, 0.06std) +0.40%, 0.06s invariant (0.96d, 0.11p, 0.06std) +0.42%, 0.01s invariant (1.03d, 0.09p, 0.01std) -0.00%, -0.0ms invariant (-0.01d, 0.99p, 0.04std) +1.55%, 0.07ms invariant (1.15d, 0.06p, 0.05std)
WGLMakie 37.25s (36.88, 37.57) 0.23+- 27.47s (27.20, 27.74) 0.18+- 41.26s (40.73, 41.83) 0.39+- 14.33ms (13.74, 14.94) 0.51+- 2.66s (2.62, 2.71) 0.03+-
master 37.20s (36.87, 37.37) 0.18+- 27.51s (27.32, 27.75) 0.18+- 41.57s (41.20, 42.16) 0.35+- 13.57ms (13.22, 14.09) 0.35+- 2.53s (2.51, 2.56) 0.02+-
evaluation +0.13%, 0.05s invariant (0.22d, 0.68p, 0.21std) -0.14%, -0.04s invariant (-0.22d, 0.69p, 0.18std) -0.73%, -0.3s invariant (-0.82d, 0.15p, 0.37std) +5.36%, 0.77ms slower❌ (1.77d, 0.01p, 0.43std) +4.74%, 0.13s slower X (5.49d, 0.00p, 0.02std)

@jkrumbiegel jkrumbiegel merged commit 4da0069 into master Dec 28, 2022
@jkrumbiegel jkrumbiegel deleted the jk/default-font-hardcoding branch December 28, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hardcode Makie's default fonts to avoid findfont latency
3 participants