-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix silent LaTeXString
conversion
#2588
Conversation
LaTexString
conversionLaTeXString
conversion
LaTeXString
conversionLaTeXString
conversion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test failure is just a communication error so this should be good to go right?
Error: Resource not accessible by integration
No, this needs new reference images merged (
|
I think there are a couple of new reference tests in this round of PRs, Simon mentioned he usually uploads those manually. |
IIUC, this can only be done by contributors with write access (which I don't have). |
True - I meant that AFAIK Simon himself uploads those manually, after merging a bunch of PRs. CC @SimonDanisch - is this good to merge? |
Missing reference imagesFound 1 new images without existing references. |
Description
Fix #2513.
In OP's bug report, the
LaTeXString
was silently converted to aString
, resulting in$
signs appearing in theAxis3D
case.Type of change
Delete options that do not apply:
Checklist