Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mesh/surface with NaN points #2598

Closed
wants to merge 27 commits into from
Closed

Fix mesh/surface with NaN points #2598

wants to merge 27 commits into from

Commits on Jan 16, 2023

  1. Do not plot faces with NaN points in meshes 

    Also allows NaN points to propagate ahead from surface to mesh.

Solves https://www.github.com/MakieOrg/GeoMakie.jl/issues/133
    @asinghvi17
    asinghvi17 committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    a5cd052 View commit details
    Browse the repository at this point in the history

  2. Update NEWS.md

    @asinghvi17
    asinghvi17 committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    079c553 View commit details
    Browse the repository at this point in the history

  3. Skip NaN faces in the other mesh methods also

    @asinghvi17
    asinghvi17 committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    d817155 View commit details
    Browse the repository at this point in the history

  4. Add NaN-aware normal calculation code 

    Basically replicates what's done in GLMakie's utils shader.  Skips any combination of points which has a NaN when computing normals.
    @asinghvi17
    asinghvi17 committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    ce2a22b View commit details
    Browse the repository at this point in the history

  5. Apply nan code only to surfaces, not meshes 

    Simplify the code a lot as well.
    @asinghvi17
    asinghvi17 committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    5440a23 View commit details
    Browse the repository at this point in the history

  6. Add a test

    @asinghvi17
    asinghvi17 committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    dd60f10 View commit details
    Browse the repository at this point in the history

  7. Fix typo

    @asinghvi17
    asinghvi17 committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    5978840 View commit details
    Browse the repository at this point in the history

  8. Move functionality from CairoMakie to Makie

    @asinghvi17
    asinghvi17 committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    9b14ec3 View commit details
    Browse the repository at this point in the history

  9. Finally fix tests 

    removed an extra 'end'
    @asinghvi17
    asinghvi17 committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    c6725f6 View commit details
    Browse the repository at this point in the history

  10. Complete the switch to Makie

    @asinghvi17
    asinghvi17 committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    3313da0 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. simplify orthogonal_vector and avoid triangles in surface

    @ffreyer
    ffreyer committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    fd93548 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. Add a better test 

    Co-committed-by: Frederic Freyer <frederic481994@hotmail.de>
    @asinghvi17
    asinghvi17 committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    9402fce View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. fix test

    @ffreyer
    ffreyer committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    4c2e4b4 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. Merge branch 'master' into as/cairomakie_surface_nan

    @asinghvi17
    asinghvi17 committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    8fb0706 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into as/cairomakie_surface_nan

    @SimonDanisch
    SimonDanisch committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    d6452c9 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2023

  1. fix NaN value rendering in GLMakie

    @ffreyer
    ffreyer committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    db0e400 View commit details
    Browse the repository at this point in the history

  2. fix WGLMakie surfaces

    @ffreyer
    ffreyer committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    2af2845 View commit details
    Browse the repository at this point in the history

  3. fix the wrong uv instead

    @ffreyer
    ffreyer committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    7ef034c View commit details
    Browse the repository at this point in the history

  4. simplify test

    @ffreyer
    ffreyer committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    8e00d10 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into as/cairomakie_surface_nan

    @ffreyer
    ffreyer committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    aa551be View commit details
    Browse the repository at this point in the history

  6. use texelFetch for normal calc

    @ffreyer
    ffreyer committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    8e79b41 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. Merge branch 'master' into as/cairomakie_surface_nan

    @ffreyer
    ffreyer committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    d82fb0e View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Merge branch 'master' into as/cairomakie_surface_nan

    @asinghvi17
    asinghvi17 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    7682d0b View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Merge branch 'master' into as/cairomakie_surface_nan

    @asinghvi17
    asinghvi17 committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    598ad24 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into as/cairomakie_surface_nan

    @SimonDanisch
    SimonDanisch committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    4e44a6b View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Merge branch 'master' into as/cairomakie_surface_nan

    @SimonDanisch
    SimonDanisch committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    338441e View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Merge branch 'master' into as/cairomakie_surface_nan

    @ffreyer
    ffreyer committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    2a0da7e View commit details
    Browse the repository at this point in the history