Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LaTeXString linesegments with offsets #2668

Merged
merged 4 commits into from
Feb 12, 2023

Conversation

jkrumbiegel
Copy link
Member

Description

Fixes #2667

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@github-actions
Copy link
Contributor

Missing reference images

Found 1 new images without existing references.
Upload new reference images before merging this PR.

@MakieBot
Copy link
Collaborator

MakieBot commented Feb 11, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 29.99s (29.90, 30.04) 0.05+- 16.64s (16.53, 16.72) 0.07+- 14.87s (14.80, 14.94) 0.05+- 9.75ms (9.66, 9.89) 0.08+- 110.19ms (109.60, 111.70) 0.77+-
master 29.95s (29.85, 29.99) 0.05+- 16.64s (16.55, 16.70) 0.05+- 14.87s (14.79, 14.92) 0.05+- 9.69ms (9.59, 9.79) 0.06+- 110.72ms (110.08, 112.06) 0.71+-
evaluation +0.16%, 0.05s invariant (1.00d, 0.08p, 0.05std) +0.02%, 0.0s invariant (0.06d, 0.92p, 0.06std) +0.04%, 0.01s invariant (0.11d, 0.85p, 0.05std) +0.68%, 0.07ms invariant (0.91d, 0.11p, 0.07std) -0.48%, -0.53ms invariant (-0.71d, 0.21p, 0.74std)
CairoMakie 32.07s (31.68, 32.38) 0.25+- 20.09s (19.79, 20.53) 0.26+- 2.99s (2.93, 3.05) 0.04+- 12.28ms (12.16, 12.51) 0.12+- 5.63ms (5.54, 5.75) 0.06+-
master 32.32s (32.05, 32.74) 0.25+- 20.28s (20.17, 20.38) 0.08+- 3.04s (3.02, 3.07) 0.02+- 12.31ms (12.14, 12.47) 0.11+- 5.76ms (5.62, 5.97) 0.14+-
evaluation -0.79%, -0.25s invariant (-1.01d, 0.08p, 0.25std) -0.92%, -0.18s invariant (-0.95d, 0.12p, 0.17std) -1.66%, -0.05s faster ✓ (-1.58d, 0.02p, 0.03std) -0.30%, -0.04ms invariant (-0.32d, 0.56p, 0.11std) -2.25%, -0.13ms invariant (-1.16d, 0.06p, 0.10std)
WGLMakie 38.59s (38.26, 38.77) 0.20+- 21.88s (21.55, 23.05) 0.53+- 22.08s (21.88, 22.28) 0.16+- 14.92ms (14.23, 15.97) 0.73+- 1.82s (1.74, 1.91) 0.06+-
master 38.66s (38.45, 38.89) 0.16+- 21.65s (21.53, 21.77) 0.09+- 22.02s (21.76, 22.50) 0.25+- 14.68ms (14.25, 15.00) 0.29+- 1.75s (1.68, 1.84) 0.06+-
evaluation -0.20%, -0.08s invariant (-0.42d, 0.45p, 0.18std) +1.03%, 0.23s invariant (0.59d, 0.31p, 0.31std) +0.30%, 0.07s invariant (0.32d, 0.56p, 0.20std) +1.60%, 0.24ms invariant (0.43d, 0.45p, 0.51std) +3.76%, 0.07s slower X (1.18d, 0.05p, 0.06std)

@MakieBot
Copy link
Collaborator

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie
master
evaluation
CairoMakie 32.29s (30.47, 34.37) 1.26+- 20.15s (19.31, 21.13) 0.57+- 3.06s (2.83, 3.33) 0.19+- 13.81ms (13.48, 14.31) 0.27+- 6.23ms (5.91, 6.69) 0.27+-
master 32.56s (31.92, 33.89) 0.65+- 20.03s (19.23, 21.07) 0.76+- 3.07s (2.84, 3.19) 0.15+- 13.60ms (13.20, 14.14) 0.33+- 5.92ms (5.64, 6.19) 0.20+-
evaluation -0.84%, -0.27s invariant (-0.27d, 0.63p, 0.95std) +0.62%, 0.12s invariant (0.19d, 0.73p, 0.66std) -0.26%, -0.01s invariant (-0.05d, 0.93p, 0.17std) +1.56%, 0.22ms invariant (0.71d, 0.21p, 0.30std) +4.92%, 0.31ms slower X (1.29d, 0.03p, 0.24std)
WGLMakie
master
evaluation

@github-actions
Copy link
Contributor

Missing reference images

Found 1 new images without existing references.
Upload new reference images before merging this PR.

@jkrumbiegel jkrumbiegel reopened this Feb 12, 2023
@jkrumbiegel jkrumbiegel merged commit 9aee7d4 into master Feb 12, 2023
@jkrumbiegel jkrumbiegel deleted the jk/fix-latex-lineseg-offset branch February 12, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Line segments in text(lstr::LaTeXString) are misplaced (align keyword is ignored)
2 participants